Review Request 120176: Suggest file buddies based on DUChain
Max Schwarz
max.schwarz at online.de
Tue Sep 16 22:27:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120176/
-----------------------------------------------------------
(Updated Sept. 16, 2014, 10:27 nachm.)
Review request for KDevelop.
Changes
-------
Rebased on master, fixed style issues and s/KUrl/QUrl/.
I don't have a KF5 workspace (yet), so I couldn't check if it still compiles and works :-(
Repository: kdev-clang
Description
-------
Many projects have source trees with split include / source folders.
In that situation the path-based buddy finder does not work. So
examine DUChain declarations/definitions and rank possible buddy files
to find the most probable one. If we found such a buddy file, add it
to the suggestions.
Of course, this improvement does not depend on kdev-clang. If you point
me towards a suitable place in kdevplatform, I can also add it there.
Diffs (updated)
-----
documentfinderhelpers.cpp e100be2
tests/test_buddies.h 0e83d9f
tests/test_buddies.cpp a252b8e
Diff: https://git.reviewboard.kde.org/r/120176/diff/
Testing
-------
Tested on a medium codebase (>100 source files) with the SwitchToBuddy shortcut (Ctrl+Alt+c). Works fine with no visible performance drop.
Tests added in the TestBuddies unit test.
Thanks,
Max Schwarz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140916/4d761572/attachment.html>
More information about the KDevelop-devel
mailing list