Review Request 120201: Port KUrl to QUrl/Adjust to platform changes

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120201/#review66472
-----------------------------------------------------------



clangsupport.cpp
<https://git.reviewboard.kde.org/r/120201/#comment46337>

    this looks wrong. you want to add one path to the other, right? Use QUrl(includeName) to make it a relative URL. And the dir you should get via
    
        const QUrl dir = url.adjusted(QUrl::RemoveFilename);
    
    the includeName you should then get via
    
        includeName = dir.resolved(QUrl(includeName)).toLocalFile();
    
    Add some normalization for good measure :) If you think thats ugly, use Path instead:
    
        const Path dir = Path(url).parent();
        includeName = Path(dir, includeName).toLocalFile()



duchain/clangducontext.cpp
<https://git.reviewboard.kde.org/r/120201/#comment46339>

    const QUrl u = url().toUrl();



duchain/macronavigationcontext.cpp
<https://git.reviewboard.kde.org/r/120201/#comment46338>

    .toLocalFile()


- Milian Wolff


On Sept. 14, 2014, 2:42 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120201/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 2:42 p.m.)
> 
> 
> Review request for KDevelop, Kevin Funk and Milian Wolff.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Port KUrl to QUrl/Adjust to platform changes
> 
> 
> Diffs
> -----
> 
>   documentfinderhelpers.cpp fc6d92d 
>   duchain/clangducontext.cpp 488a54f 
>   duchain/macronavigationcontext.cpp 447e4ff 
>   duchain/parsesession.h 8e653c4 
>   tests/test_assistants.cpp f1fe2c5 
>   tests/test_buddies.h 1c6f8f3 
>   tests/test_buddies.cpp 36eb52a 
>   tests/test_problems.cpp 376734d 
>   codegen/clangsignatureassistant.cpp 6f1ad52 
>   documentfinderhelpers.h 0672732 
>   codecompletion/model.cpp b31e856 
>   codegen/adaptsignatureassistant.h 59968a5 
>   codegen/adaptsignatureassistant.cpp 4ef1642 
>   codegen/clangsignatureassistant.h b83a0a7 
>   CMakeLists.txt cd32351 
>   clangsupport.h b76af87 
>   clangsupport.cpp 71589b7 
>   codecompletion/model.h 24a5c82 
> 
> Diff: https://git.reviewboard.kde.org/r/120201/diff/
> 
> 
> Testing
> -------
> 
> Tests run, failures don't seem related.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140914/05eb8255/attachment.html>