Review Request 120190: port away from KStandardDirs

[Sven Brauch]

> On Sept. 13, 2014, 8:47 p.m., Sven Brauch wrote:
> > Very nice, thanks a lot!
> > 
> > When porting the snippets stuff in kate, I noticed that GenericDataLocation doesn't seem to be what you usually want ... did you test where the data actually ends up?
> > 
> > Do all the tests still pass after you applied this patch?
> 
> Sven Brauch wrote:
>     ... I forgot, the thing I used instead in kate was DataLocation instead of GenericDataLocation.
> 
> Laurent Navet wrote:
>     no, didn't test this, because tests were falling before, and for now, even kdevelop don't start properly, I need to fix my setup first

I can try to assist if you like, ping me in #kdevelop. The tests should all pass, as far as I'm aware I fixed them all.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120190/#review66432
-----------------------------------------------------------


On Sept. 13, 2014, 8:37 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120190/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 8:37 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> replace deprecated KStandardDirs by QStandardPaths
> 
> 
> Diffs
> -----
> 
>   pythonlanguagesupport.cpp 397bd41 
>   codecompletion/context.cpp cd88efd 
>   codecompletion/tests/pycompletiontest.cpp d55430f 
>   debugger/debugjob.cpp 504971f 
>   debugger/debugsession.cpp bbcafe9 
>   docfilekcm/docfilemanagerwidget.cpp 88ab17a 
>   docfilekcm/docfilewizard.cpp da104c5 
>   duchain/assistants/missingincludeassistant.cpp 0b53a74 
>   duchain/contextbuilder.cpp 99c4d9c 
>   duchain/correctionhelper.cpp 04eb329 
>   duchain/helpers.cpp 7676be6 
>   duchain/tests/duchainbench.cpp 4c717e9 
>   duchain/tests/pyduchaintest.cpp c587442 
> 
> Diff: https://git.reviewboard.kde.org/r/120190/diff/
> 
> 
> Testing
> -------
> 
> just build
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/b303a90d/attachment.html>