Review Request 119972: Plugin loading without kbuildsycoca (however still required for KCMs)
Alexander Richardson
arichardson.kde at gmail.com
Sat Sep 13 16:32:09 UTC 2014
> On Aug. 29, 2014, 5:57 nachm., Milian Wolff wrote:
> > thanks, this looks good. some nit picks and a question on my side. otherwise looks good
>
> Milian Wolff wrote:
> ping? do you plan to ship this anytime soon?
Was on holiday until today without an internet connection, so I couldn't answer earlier. Sorry. I'll try to fix the mentioned issues by tomorrow.
> On Aug. 29, 2014, 5:57 nachm., Milian Wolff wrote:
> > plugins/appwizard/CMakeLists.txt, line 35
> > <https://git.reviewboard.kde.org/r/119972/diff/2/?file=308406#file308406line35>
> >
> > just double checking: this generates the kdevappwizard.json, right? so these files are not missing in this review request?
Correct, this gernerates those files.
> On Aug. 29, 2014, 5:57 nachm., Milian Wolff wrote:
> > plugins/git/gitpluginmetadata.cpp, line 31
> > <https://git.reviewboard.kde.org/r/119972/diff/2/?file=308436#file308436line31>
> >
> > here and elsewhere: yes, that would be the better approach (i.e. use an object library)
Will update to fix this issue
> On Aug. 29, 2014, 5:57 nachm., Milian Wolff wrote:
> > shell/settings/ccpreferences.cpp, line 52
> > <https://git.reviewboard.kde.org/r/119972/diff/2/?file=308479#file308479line52>
> >
> > these lines could/should be removed everywhere, imo.
Will fix
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119972/#review65520
-----------------------------------------------------------
On Aug. 29, 2014, 4:36 nachm., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119972/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 4:36 nachm.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> This iterates over all plugins in the kdevplatform/$KDEVPLATFORM_VERSION
> subdirectories of QCoreApplication::libraryPaths and will then include
> all plugins that contain "KDevelop/Plugin" in their service types.
>
> This meta data is now embedded directly in the shared libraries, there
> is no more need for kbuildsycoca and .desktop files.
>
> This means we now require KCoreAddons 5.2 and KService 5.2
>
>
> For testing I converted KDevWelcomepage to the new JSON metadata and it
> loads fine. If this approach is deemed correct I will convert the other plugins.
>
>
> It requires https://git.reviewboard.kde.org/r/119970/ to get committed first.
>
>
> Diffs
> -----
>
> plugins/executescript/executescriptplugin.cpp a170439a20e85fa660ecd705f1dd0022bd1b7625
> plugins/externalscript/CMakeLists.txt 93d459bb0780efe7534d7dfc3e19fe7349192fde
> plugins/externalscript/externalscriptplugin.cpp 3d5c8fa3c8c748e5d64c31079c1848bbd2da851e
> plugins/filemanager/CMakeLists.txt 2ea0539e588bf58482a219c3000d2e5e4379047f
> plugins/filemanager/kdevfilemanagerplugin.cpp f36b3d3b908a2ba354a2fcf10f90bf3dd4674fb4
> plugins/execute/executeplugin.cpp 6a1c30f1792cb094f2f06ca03d64981ed90f97cd
> plugins/executescript/CMakeLists.txt 67381f93d4e84aa2b0338c8195d43e14fd92b9e1
> plugins/documentview/CMakeLists.txt 9f1483e0b8d5c74c3de13fa989e2e7b995906c5e
> plugins/documentview/kdevdocumentviewplugin.cpp 395e1d9d58ec6c2ae5b81a74fa75bd9e372c2f3b
> plugins/execute/CMakeLists.txt 8f2e01b86f1e382e45ea5ff6bbce205710a52609
> plugins/codeutils/codeutilsplugin.cpp bf21766fad6a5cb634604bb00c91dd66c3f83425
> plugins/contextbrowser/CMakeLists.txt e2cf7f63c608520a5cd024ca3bcf22549b8200cd
> plugins/contextbrowser/contextbrowser.cpp 155da65df82d538f5cf443e782c4bd6cd25a278e
> plugins/cvs/CMakeLists.txt 93d6cecd8f52c0b2f4b49de76a5b1661e0432ace
> plugins/documentswitcher/CMakeLists.txt 46a779c4cf56f1a4387915dd3d3f030d33b0e284
> plugins/documentswitcher/documentswitcherplugin.cpp 7a4c3c17c79e626ed852caae9a697228cff45cb0
> plugins/bazaar/bazaarpluginmetadata.cpp PRE-CREATION
> plugins/classbrowser/CMakeLists.txt c5d61a37811999844ae759c5e97821d52e92ab2d
> plugins/classbrowser/classbrowserplugin.cpp 13416c6325d8e282df492e4eee20ef4fbfca6f9e
> plugins/codeutils/CMakeLists.txt 12c3ce390dfaa62c1fecdff932d1181318622e9f
> CMakeLists.txt 77836881f8a667c86efa883c87921748a42da714
> plugins/appwizard/CMakeLists.txt 7fb59bac3396c7b061e0532cb1a4a822ba9fce87
> plugins/appwizard/appwizardplugin.cpp e14b140e9ba4fb195c3d2df214cfc01bb3248a21
> plugins/bazaar/CMakeLists.txt 17820ea528abfe0b8b9cb610edddbe00bc5b02f2
> plugins/bazaar/bazaarplugin.cpp c94612cb41453295d16a9500586a256606c6fdc5
> plugins/projectfilter/projectfilterprovider.cpp 1ff1ec8a03c817f18e0462fbbf2c6b4fe79977a9
> plugins/projectmanagerview/CMakeLists.txt 7720a60477f0074ebeb34976459a8a6db38b941e
> plugins/projectmanagerview/projectmanagerviewplugin.cpp 19e487eda653e1de53d47526bedd9d5b84cd7a88
> plugins/quickopen/CMakeLists.txt 624513e1cfaa13cd2399f90a5ce76295644fba27
> plugins/quickopen/quickopenplugin.cpp c49df9ddb9e105c5ef77a3b3d59e338654f687b9
> plugins/pastebin/pastebinplugin.cpp 1a53d744ea28fb3b2f60c98b6a6b3a820aacf3b3
> plugins/patchreview/CMakeLists.txt 02720119fc44770c6ee7a14d1d03184b284db791
> plugins/patchreview/patchreview.cpp 0195d372d59571fd8714988bbea73d1ac87c9783
> plugins/problemreporter/CMakeLists.txt 25fbdcec795f1cb0c0fe1a3a14fc841a303af766
> plugins/problemreporter/problemreporterplugin.cpp 2c44cca3bd76e23333a90f6799042e989e27cb82
> plugins/projectfilter/CMakeLists.txt e922f5c937f17181ad4eb3ca054440df017c85a5
> plugins/projectfilter/projectfilterkcm.cpp 5a59115151702573b95000f4b66b351bcca02710
> plugins/pastebin/CMakeLists.txt 9d2d4cba0120601fc5b314b056ebd033e6ab69b3
> plugins/git/gitpluginmetadata.cpp PRE-CREATION
> plugins/grepview/CMakeLists.txt 84d66cf9634a359b64ec082689258eba286882e8
> plugins/grepview/grepviewplugin.cpp 310000a32f00e7736f8fba49bfdd0924fb44b533
> plugins/grepview/grepviewpluginmetadata.cpp PRE-CREATION
> plugins/konsole/CMakeLists.txt 2f536b36b062f1caed254c6ef3a9843cbf3453bf
> plugins/konsole/kdevkonsoleviewplugin.cpp ac8a4816a43f73b0feeae5f9a3db19a501748394
> plugins/openwith/CMakeLists.txt 407777482ef2c88461716c7290a7310125abcbbf
> plugins/openwith/openwithplugin.cpp b80916232ab451fe0cdcbae3c4c2283444270318
> plugins/filetemplates/CMakeLists.txt f9ba4d437000e08a448c3865f24398d3eb54f164
> plugins/filetemplates/filetemplatesplugin.cpp 4fa5a2cb1b65d2822505020c7d7e378d58fec3d8
> plugins/genericprojectmanager/CMakeLists.txt 427323c4ebec756801c6a62fa3e284862f00cde8
> plugins/genericprojectmanager/genericmanager.cpp 4b563605be98e2a92c6d0d693f218b3ebf110c6a
> plugins/git/CMakeLists.txt 35acdea2790646aa1aa2b183043c34b2e10d2244
> plugins/git/gitplugin.cpp 9fe04a0c7485371959a476bea0168aba69705c9c
> plugins/reviewboard/CMakeLists.txt 9cda85342f725f7968380648a381242313c1930f
> plugins/reviewboard/reviewboardplugin.cpp 63c73ca3ccb69e35efd3a35c5d5cf84930001234
> plugins/snippet/CMakeLists.txt 2305b7863be1ba0796b91732dda79e74e777cd96
> plugins/snippet/snippetplugin.cpp d9d1a08df3fe0574c69c8f1b54cb8c405adfae3d
> plugins/standardoutputview/CMakeLists.txt 38d8cb82a98b9ac19086a17f392f61b2e189635f
> plugins/standardoutputview/standardoutputview.cpp ed9c035d1e15eb4389c2bdbb39a43f06d06ab948
> plugins/subversion/CMakeLists.txt 2a31e21165cd05f2537ad9485dcc3fe86f1efd6b
> plugins/subversion/kdevsvnplugin.cpp a87343d511e9515cd82cf3fe693ce36daf07cb59
> plugins/switchtobuddy/CMakeLists.txt 382cc20ba503ac5e687c9bc5c920309cc6236aeb
> plugins/switchtobuddy/switchtobuddyplugin.cpp bad7dbba8c56c87ce23a5ea5b513ca30160c0ecf
> plugins/templatemanager/CMakeLists.txt 4946c7924d5b24731f25a62bf27294b14fb4b412
> plugins/templatemanager/templateconfig.cpp d7c0371bc44ff81f17e6faf6c0c6408e837d45a5
> plugins/testview/CMakeLists.txt 10eec21d9725ed5647fc4dff9d065c592e66e6c9
> plugins/testview/testviewplugin.cpp 52b16e4ff4d309f5a9715e44f2b74d5bf27589a1
> plugins/vcschangesview/CMakeLists.txt c0142e8d73ea3175e0fa47823e93ae6a646a319b
> plugins/vcschangesview/vcschangesviewplugin.cpp 465635fbdd7ab10ca1b35a9d506a6336e0e5a388
> plugins/welcomepage/CMakeLists.txt 34ee3302fadd8a85a66dd2f5b776f0aa09468afb
> plugins/welcomepage/kdevwelcomepageplugin.desktop.cmake
> plugins/welcomepage/welcomepageplugin.cpp d24317e7767600d2774972ace8a4f1f708c565d1
> shell/plugincontroller.cpp 1acb54b5cd6aad61abbb515bb7b4a6aa536c7d22
> shell/settings/CMakeLists.txt 68d346165182db31f293577c1e9ae3869f1e7001
> shell/settings/bgpreferences.cpp c3a8edac80141576707e7af1484262fed6796d10
> shell/settings/ccpreferences.cpp 289390e2be6382eaf0950dc4bda85adc99ea540c
> shell/settings/environmentpreferences.cpp 95e41d853da3090f69cc0abdd3df8a3de602984c
> shell/settings/pluginpreferences.cpp 8d168c8d76a521c28be8cd452be66542875bf5c7
> shell/settings/projectpreferences.cpp 9c605a19f459bd7daaa21f6f3184aa57afe60177
> shell/settings/sourceformattersettings.cpp 31d5efec5f4512eb6b9a06453038df8f0b89849d
> shell/settings/uipreferences.cpp 3bf2e82e5a6202ccba3de862ee6f89c7dacd563a
>
> Diff: https://git.reviewboard.kde.org/r/119972/diff/
>
>
> Testing
> -------
>
> Welcomepage loads fine when opening kdevelop, other plugins are still loaded. It new finds 26 new style plugin and 17 old style ones (from kdevelop since that is not ported yet)
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/c1de7db1/attachment-0001.html>
More information about the KDevelop-devel
mailing list