Review Request 120176: Suggest file buddies based on DUChain

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120176/#review66407
-----------------------------------------------------------

Ship it!


Some more minor nitpicks. Feel free to fix and commit if you have a developer account. Otherwise someone else can do that for you.

Thanks for your contribution!


tests/test_buddies.h
<https://git.reviewboard.kde.org/r/120176/#comment46314>

    please use `QString()` instead



tests/test_buddies.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46315>

    DocumentController::closeAllDocuments()
    
    is probably sufficient, no?



tests/test_buddies.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46316>

    that is obsoleted by the check in `init()`.


- Milian Wolff


On Sept. 13, 2014, 3:02 p.m., Max Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120176/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 3:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Many projects have source trees with split include / source folders.
> In that situation the path-based buddy finder does not work. So
> examine DUChain declarations/definitions and rank possible buddy files
> to find the most probable one. If we found such a buddy file, add it
> to the suggestions.
> 
> Of course, this improvement does not depend on kdev-clang. If you point
> me towards a suitable place in kdevplatform, I can also add it there.
> 
> 
> Diffs
> -----
> 
>   documentfinderhelpers.cpp 6535ab9 
>   tests/test_buddies.h 1c6f8f3 
>   tests/test_buddies.cpp da1fcea 
> 
> Diff: https://git.reviewboard.kde.org/r/120176/diff/
> 
> 
> Testing
> -------
> 
> Tested on a medium codebase (>100 source files) with the SwitchToBuddy shortcut (Ctrl+Alt+c). Works fine with no visible performance drop.
> Tests added in the TestBuddies unit test.
> 
> 
> Thanks,
> 
> Max Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/2e37fb75/attachment.html>