Review Request 120176: Suggest file buddies based on DUChain

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120176/#review66401
-----------------------------------------------------------


Yay nice patch - I like it. Below are some nitpicks which make the code a bit simpler, imo.

cheers


documentfinderhelpers.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46306>

    can be simplified to
    
        void vote(const KUrl& url)
        {
            m_buddyFiles[url]++;
        }
    
    `operator[]` of QMap and QHash will insert a default constructed value if it does not exist. For integers, that is zero.



documentfinderhelpers.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46305>

    could be simplified to:
     
        if (type1.second != type2.second)



tests/test_buddies.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46307>

    This should be rewritten using KDevelop::TestFile.



tests/test_buddies.cpp
<https://git.reviewboard.kde.org/r/120176/#comment46308>

    This should/could be handled in the generic `cleanup()` function, which will be called after every test function. That way, if a check before fails and the function context is left, the documents will still be closed.


- Milian Wolff


On Sept. 13, 2014, 1:10 p.m., Max Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120176/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 1:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Many projects have source trees with split include / source folders.
> In that situation the path-based buddy finder does not work. So
> examine DUChain declarations/definitions and rank possible buddy files
> to find the most probable one. If we found such a buddy file, add it
> to the suggestions.
> 
> Of course, this improvement does not depend on kdev-clang. If you point
> me towards a suitable place in kdevplatform, I can also add it there.
> 
> 
> Diffs
> -----
> 
>   documentfinderhelpers.cpp 6535ab9 
>   tests/test_buddies.h 1c6f8f3 
>   tests/test_buddies.cpp da1fcea 
> 
> Diff: https://git.reviewboard.kde.org/r/120176/diff/
> 
> 
> Testing
> -------
> 
> Tested on a medium codebase (>100 source files) with the SwitchToBuddy shortcut (Ctrl+Alt+c). Works fine with no visible performance drop.
> Tests added in the TestBuddies unit test.
> 
> 
> Thanks,
> 
> Max Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/55da67d6/attachment.html>