Review Request 120166: Fix ranges for CXCursor_MacroExpansion

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120166/#review66386
-----------------------------------------------------------

Ship it!



tests/files/macros.cpp
<https://git.reviewboard.kde.org/r/120166/#comment46303>

    You're right. You can't 'document' (macro) function calls, hence Clang won't attach the doxygen comment to this AST node.
    
    Just drop the line.


Looks good to me. Thanks.

- Kevin Funk


On Sept. 12, 2014, 3:16 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120166/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 3:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Seems like Clang returns wrong ranges for it.
> 
> 
> Diffs
> -----
> 
>   duchain/tuduchain.cpp 7d9b021 
>   tests/files/macros.cpp 6c4d41b 
>   tests/test_duchain.h 6ad3983 
>   tests/test_duchain.cpp 8c61283 
> 
> Diff: https://git.reviewboard.kde.org/r/120166/diff/
> 
> 
> Testing
> -------
> 
> Added an unit test for it.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140913/21518d82/attachment.html>