Review Request 119938: Switch to QApplication in reviewboard test
Kevin Funk
kfunk at kde.org
Fri Sep 12 23:16:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review66381
-----------------------------------------------------------
Ship it!
plugins/reviewboard/reviewboardjobs.h
<https://git.reviewboard.kde.org/r/119938/#comment46302>
Nitpick: Break before ':'
- Kevin Funk
On Sept. 12, 2014, 3:30 p.m., Dāvis Mosāns wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 3:30 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Switch to QApplication in reviewboard test
>
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
>
>
> Diffs
> -----
>
> plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea
> plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5
> plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa
>
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
>
>
> Testing
> -------
>
> Compiles and seems to be working.
>
>
> Thanks,
>
> Dāvis Mosāns
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/7c4f1249/attachment.html>
More information about the KDevelop-devel
mailing list