Review Request 120164: CMake: Make JSON import threaded

Kevin Funk kfunk at kde.org
Fri Sep 12 15:48:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120164/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 3:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Aleix Pol Gonzalez.


Repository: kdevelop


Description
-------

CMake: Make JSON import threaded

Before this patch parsing the compile_commands.json file blocked the
main thread. Make the parsing async instead.

The tests are quite broken right now (due to the refactoring), I cannot really test using them.


Diffs
-----

  projectmanagers/cmake/CMakeLists.txt 148d9f3743af1b2f9a74ee897d8eaef5809ef5d2 
  projectmanagers/cmake/cmakeimportjsonjob.h PRE-CREATION 
  projectmanagers/cmake/cmakeimportjsonjob.cpp PRE-CREATION 
  projectmanagers/cmake/cmakemanager.h cc5ea0b205bebaab9e244bee80533aebe276a37d 
  projectmanagers/cmake/cmakemanager.cpp ba8746cb0b04a98056cb77b4258fb6de921cbc8e 
  projectmanagers/cmake/cmakeprojectdata.h fbe33122be81bb1a5e6eda7273e6ed4c397b841a 

Diff: https://git.reviewboard.kde.org/r/120164/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/05cc30c0/attachment-0001.html>


More information about the KDevelop-devel mailing list