Review Request 119830: Remove deprecated IProject methods

Dāvis Mosāns davispuh at gmail.com
Fri Sep 12 15:23:21 UTC 2014


> On Sept. 11, 2014, 12:47 a.m., Milian Wolff wrote:
> > Hey,
> > 
> > I screwed up and forgot that your url patch depends on this one. My fault. I'll take this one up and rebase it on top of my local KUrl porting patch - ok? I'll also handle the KDevelop port.
> > 
> > cheers

I've them locally rebased. And yeah this wasn't fun work at all :D


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119830/#review66196
-----------------------------------------------------------


On Aug. 18, 2014, 7:42 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119830/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 7:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove deprecated IProject methods. No need to keep them, when KUrl will be changed to QUrl signatures would be different anyway, so just remove now.
> 
> 
> Diffs
> -----
> 
>   tests/testproject.h bbff5a3a193ffbb83d77e55d169082252f177d38 
>   shell/project.cpp 1a4a1c3d54fb84b2c2ce919d3829fcc9ba897f33 
>   shell/project.h 0452dd7273c83696d6709997e2bb81cd9e553a1c 
>   project/projectmodel.cpp 6791c48285a698fffa9eec348e512061e85cca06 
>   project/projectmodel.h 5d77958b08d288a79e9f23bf4d248c3cb3945f7d 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp c478ff8ddce4738222fe82ab8e03c1a54f07cd4f 
>   plugins/projectmanagerview/projectmanagerview.cpp 781cf49a19697744899bcebbc4463e88b7023375 
>   plugins/grepview/grepdialog.cpp 6034191c4257fdbb6a2d6311f07503bb3931f0e2 
>   plugins/filetemplates/templateclassassistant.cpp 4e8604513d48f3170bc4cdf91578a58722e1cfa1 
>   plugins/externalscript/externalscriptjob.cpp aaef1b3e7ad0b3cc10bfc122ff7bfed54158479a 
>   plugins/executescript/scriptappconfig.cpp e4e7fbdb13d76ddb524a80dd2ff45c1a30e8ffb4 
>   plugins/execute/nativeappconfig.cpp ab406e3bb71a53a122d2c9566b0fb8c958b15db7 
>   plugins/dashboard/kdevprojectdashboard.cpp e08b4b4e86265413cda67da0b932763f0d258dd3 
>   plugins/dashboard/dashboardview.cpp 11233433fb71c804a298ae3947f80cf48504cc2b 
>   plugins/dashboard/dashboarddocument.cpp 2faac45529f342a9304261eba3e1316e1d9b3329 
>   plugins/dashboard/dashboarddataengine.cpp 332f1d27218f52d5fff5866d6d6345a4ee16b5f2 
>   vcs/models/brancheslistmodel.cpp f2fbe0dda21deff587575ba4d350762037449529 
>   vcs/models/projectchangesmodel.h ae6eec5ae26a49fa492dbd9ddf04fdb3e85c7d43 
>   vcs/models/projectchangesmodel.cpp 1308b8b12208ab94f0c536af8ee77a91966061bb 
>   vcs/vcspluginhelper.h 596f8a90d76097343ea99175617ce569d33ecd23 
>   vcs/vcspluginhelper.cpp 949b336784391c3f812e8c29eb807aa3d2403c2e 
>   interfaces/iproject.h f884642b5033a710d43e7fc7eee1192fb47a245b 
>   shell/projectcontroller.cpp 140771bf8547f8faa441e9c9380a5dde850e786f 
>   shell/documentcontroller.cpp d5e7c3b1c58cc389e1c9fb887e24c5a745efe73a 
>   tests/testproject.cpp b7530a8cad17be4d983f9bccb513d06feef5f2eb 
> 
> Diff: https://git.reviewboard.kde.org/r/119830/diff/
> 
> 
> Testing
> -------
> 
> Tests does pass :)
> 
> but note that KDevelop must also be updated and currently it won't compile against this because it still uses these deprecated methods.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/d15247d4/attachment-0001.html>


More information about the KDevelop-devel mailing list