Review Request 120086: Fix cursorSpellingNameRange range for out-of-line functions.

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120086/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 6:36 p.m.)


Review request for KDevelop and Kevin Funk.


Changes
-------

I've removed that TUDUChain::makeId workaround, as:

1. With it we use wrong ranges for out-of-line methods (especially noticeable with code-highlighting)
2. It breaks refactoring capabilities for out-of-line methods.

So, even if we need the "toString" method of the test to be "SomeClass::someClassFunc", it should be implemented in a more appropriate way.


Repository: kdev-clang


Description
-------

This was accidentally broken by:
f17866db1bc24c198e87c028065796959f6dd135
Author: Kevin Funk <kfunk at kde.org>
Date:   Mon Aug 4 16:53:06 2014 +0200

    Also fix ranges for operator functions


Diffs (updated)
-----

  duchain/tuduchain.cpp 7d9b021 
  tests/files/functiondefinitiondeclarations.cpp fe4050e 

Diff: https://git.reviewboard.kde.org/r/120086/diff/


Testing
-------

All tests pass.


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/cdcd1da3/attachment.html>