Review Request 120150: [OS X] prevent another crash after finishing a code difference review

[René J.V. Bertin]

> On Sept. 12, 2014, 1:44 a.m., Aleix Pol Gonzalez wrote:
> > Hi René,
> > Why don't you join us and work on master to get a good KDevelop 5 on OS X? I think it's a much better way to work towards a future-proof position in the Mac world.
> 
> Ian Wadham wrote:
>     Hands off, Aleix!  We need René over here on KDE for Apple OS X for a while!
>     
>     On Apple OS X, there are *dozens* of serious problems that need fixing in several KDE 4 apps and even, perhaps especially, in KDE 4 *core* and we are slowly working our way through them.  The resulting fixes will also be applicable to KF 5 for Apple OS X.  It is worth fixing these things in KDE 4 because there is a likely lag of a year or two (or three) before KDE software on Apple OS X will ALL be at version 5.x.
>     
>     We also have a project to implement Jenkins CI for Apple OS X on Frameworks and KF 5, to prevent a situation like this from developing in the future.  That is proceeding very nicely and that is our "future-proofing".
> 
> René J.V. Bertin wrote:
>     Hi Aleix,
>     I appreciate the invitation, but I wouldnd't be of more help (if at all, see below) working on KDevelop 5. It'd be a hell of a project to learn KDE AND Qt, both of which I'm doing while working to resolve issues with currently existing KDE ports (used as MacPorts uses the term). That is my initial (and I think still main) motivation: being able to use what's there already, the way it's intended to be used.
>     
>     Also, as Ian pointed out, there is a lot of work going on bringing KF5 to OS X that's frankly a bit above my head or at least beyond what I think I could set up on my machine (not exactly slow but still already 3y old and I'm very reluctant to upgrade it to OS X 10.9) and still be able to use it for my other everyday stuff.
>     Bottomline, I've promised myself not to touch KF5 on OS X until I can have both versions installed side by side - and TBH I'd want that to be through MacPorts to avoid installing too much things twice.
> 
> René J.V. Bertin wrote:
>     Another thought: suppose there were indeed a cross-thread aspect to this crash, wouldn't that also cause issues on Linux?

Before I start adding ASSERTs wildly:

Yesterday's crash was after I had saved a diff file to file. It seems that patchreview uses another plugin (pastebin) for uploading a diff to pastebin; does it do the same for sending it to a file?


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120150/#review66304
-----------------------------------------------------------


On Sept. 12, 2014, 10:52 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120150/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 10:52 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDevelop and Olivier Goffart.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp 18b63db 
> 
> Diff: https://git.reviewboard.kde.org/r/120150/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/cf62fc46/attachment.html>