Review Request 120150: [OS X] prevent another crash after finishing a code difference review

[René J.V. Bertin]

> On Sept. 12, 2014, 11:49 a.m., Kevin Funk wrote:
> > Let me chime in here...
> > 
> > I'm heavily agreeing with Milian here -- don't just blindly plaster QObject::deleteLater calls just everywhere. They make it even harder to debug the application.
> > 
> > Anyway, about the actual bug you're trying to fix: 
> > - Is it the same backtrace as in https://bugs.kde.org/show_bug.cgi?id=338829?
> > - If so, please try to make sure you also get line numbers in the backtrace (currently it's quite useless)
> > - Run KDevelop through valgrind (should be available on OSX) or some XCode memory analyzer, provide the dump here after the crash happened. Check why/where qt_mac_getTargetForMouseEvent fails.
> > 
> > At any rate, please try to find the real issue first.
> 
> Kevin Funk wrote:
>     Note: It's also quite pointless to add copyright holders from random Qt headers -- again, please try to find out what's going on first.

Yes, it's the same backtrace.
Getting line numbers in there would require me to rebuild Qt4-mac from source, I'll see if I can manage to do that AND ensure that debug information isn't stripped - when I don't need the computer for anything else for a couple of hours ...

valgrind exists on OS X, but has the nasty habit of causing KPs at least when analysing GUI code. So that's not going to help. I'd have to see what other "instruments" Xcode provides that function independently from a valid Xcode project (one which builds the target to analyse).


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120150/#review66328
-----------------------------------------------------------


On Sept. 12, 2014, 10:52 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120150/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 10:52 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDevelop and Olivier Goffart.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp 18b63db 
> 
> Diff: https://git.reviewboard.kde.org/r/120150/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/ac730077/attachment.html>