Review Request 120150: [OS X] prevent another crash after finishing a code difference review

[Ian Wadham]

> On Sept. 11, 2014, 11:44 p.m., Aleix Pol Gonzalez wrote:
> > Hi René,
> > Why don't you join us and work on master to get a good KDevelop 5 on OS X? I think it's a much better way to work towards a future-proof position in the Mac world.

Hands off, Aleix!  We need René over here on KDE for Apple OS X for a while!

On Apple OS X, there are *dozens* of serious problems that need fixing in several KDE 4 apps and even, perhaps especially, in KDE 4 *core* and we are slowly working our way through them.  The resulting fixes will also be applicable to KF 5 for Apple OS X.  It is worth fixing these things in KDE 4 because there is a likely lag of a year or two (or three) before KDE software on Apple OS X will ALL be at version 5.x.

We also have a project to implement Jenkins CI for Apple OS X on Frameworks and KF 5, to prevent a situation like this from developing in the future.  That is proceeding very nicely and that is our "future-proofing".


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120150/#review66304
-----------------------------------------------------------


On Sept. 11, 2014, 10:22 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120150/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp 18b63db 
> 
> Diff: https://git.reviewboard.kde.org/r/120150/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/c128d6d8/attachment.html>