Review Request 120150: [OS X] prevent another crash after finishing a code difference review

[Milian Wolff]

> On Sept. 11, 2014, 10:59 p.m., Milian Wolff wrote:
> > No really, this just shows that something else is wrong here. Maybe fixed the bug in Qt then. But doing this kind of hit-and-run patching, blindly trying to workaround a bug is really bad as it greatly increases the maintenance cost.
> > 
> > Could you please ensure that no threads are involved? Add stuff like Q_ASSERT(QThread::currentThread() == thread()) to the dtor of the class.
> > If that does not help, then certainly there is a bug elsewhere, maybe inside Qt, and should be fixed there then.
> 
> René J.V. Bertin wrote:
>     I take it you're talking about the descructor for the classes I use `deleteLater` on in this 2nd patch?
>     
>     Is there a Qt call to check if an object has pending events or (better yet?) flush events for an objects fromt the queue?

Yes, and also in the first patch which should be reverted, I guess.

And Qt removes pending events from the event queue when an object is deleted. *Only* when threads are involved there might be race conditions. But here, there should not be any threads.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120150/#review66302
-----------------------------------------------------------


On Sept. 11, 2014, 10:22 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120150/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 10:22 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In https://reviewboard.kde.org/r/120081/ I proposed an (accepted) approach to prevent kdevelop from crashing after closing the patch review ("git/show differences") toolview. I had another of those crashes after heavier-than-usual perusal of the toolview, despite the previous patch. The attached patch replaces all `delete`s of `QObject` derived class instances with `deleteLater()`.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp 18b63db 
> 
> Diff: https://git.reviewboard.kde.org/r/120150/diff/
> 
> 
> Testing
> -------
> 
> kdevplatform git/kde4-legacy on KDE/MacPorts OS X 10.6.8 . 
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140912/7973361c/attachment.html>