Review Request 120123: Port KUrl to QUrl

Milian Wolff mail at milianw.de
Wed Sep 10 08:26:25 UTC 2014 


> On Sept. 9, 2014, 10:30 p.m., Dāvis Mosāns wrote:
> > serialization/indexedstring.cpp, line 260
> > <https://git.reviewboard.kde.org/r/120123/diff/1/?file=310937#file310937line260>
> >
> >     Currently paths to `IndexedString` can be passed both ways, file:///tmp or /tmp
> >     
> >     But IMO best way would be to use full file:/// form everywhere internally and convert to other form only when actually using it, ie. to display to user or to pass to function which expects local file.

The proper fix for that would be to get an IndexedPath class and use that everywhere. I have that planned for a long time but didn't get there yet. Anyhow, I agree with you that `file:///` should be used for now everywhere to make it explicit. You don't have to work on that though.

I plan to apply your patch locally later today and start working with and on it. Many thanks for doing this tedious work - it's much appreciated.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120123/#review66160
-----------------------------------------------------------


On Sept. 9, 2014, 9:41 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120123/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 9:41 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port KUrl to QUrl
> 
>   * KUrl::List => QList<QUrl>
>   * KUrl => QUrl::fromLocalFile or fromUserInput or QUrl()
>   * pathOrUrl => toString
>   * prettyUrl => toDisplayString(QUrl::PreferLocalFile)
>   * upUrl => resolved("..")
>   * addPath => resolved or setPath(path() + )
>   * relativeUrl => mid(length())
>   * cleanPath => adjusted(QUrl::NormalizePathSegments) or toString(QUrl::NormalizePathSegments)
>   * adjustPath => adjusted
>   * KUrl::RemoveTrailingSlash => QUrl::StripTrailingSlash
> 
> 
> Diffs
> -----
> 
>   plugins/problemreporter/problemtreeview.cpp b1af65bef3e0263b209cd88489e5e997d6e0ccc2 
>   plugins/projectmanagerview/projectmanagerview.cpp 781cf49a19697744899bcebbc4463e88b7023375 
>   plugins/projectmanagerview/projectmanagerviewplugin.h b96808314feb3d3246295d38896d7e9b890ea5c7 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 19e487eda653e1de53d47526bedd9d5b84cd7a88 
>   plugins/projectmanagerview/projecttreeview.h 8b311b0ba219335b3236002cc7bec04f4d89a67b 
>   plugins/projectmanagerview/vcsoverlayproxymodel.h 5ae9aa6815f9ca5c0cea2117502092b973d12449 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp c478ff8ddce4738222fe82ab8e03c1a54f07cd4f 
>   plugins/quickopen/duchainitemquickopen.cpp 122bf576ed09858b3d66ff852501700a43af68e2 
>   plugins/quickopen/projectfilequickopen.cpp d7db49c7d5569b192e6ce91a218adc594aebb7b1 
>   plugins/quickopen/quickopenplugin.h f793dd21a8a4f8ab7c0000d41c6bf66e88c1596e 
>   plugins/quickopen/quickopenplugin.cpp c49df9ddb9e105c5ef77a3b3d59e338654f687b9 
>   plugins/quickopen/tests/test_quickopen.cpp cc1d10ecdf018c6e5aeadf7a967876e5abce8869 
>   plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea 
>   plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5 
>   plugins/reviewboard/reviewboardplugin.cpp 63c73ca3ccb69e35efd3a35c5d5cf84930001234 
>   plugins/reviewboard/reviewpatchdialog.h 8b26f2a2c2f2b2ce0604f5594bdeb36b0f05525f 
>   plugins/reviewboard/reviewpatchdialog.cpp 54c5ee72506c8d35564c8ed7fb7ad6d70345cc7f 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
>   plugins/subversion/kdevsvnplugin.h 20656ca93f36fe81d30d88dec6194a5be619862b 
>   plugins/subversion/kdevsvnplugin.cpp a87343d511e9515cd82cf3fe693ce36daf07cb59 
>   plugins/subversion/svnaddjob.h d08f7114171b6b4960b4d2ce9825e53b2cad6a77 
>   plugins/subversion/svnaddjob.cpp 93856a32291667adb89b1653240fc95ec24b32ee 
>   plugins/subversion/svnaddjob_p.h 38ef5ed97a723188c1d37a1daaa1dc5e1f10ef9b 
>   plugins/subversion/svnblamejob.h c7c8f0590e5360851b7c11d5096ca002e2951819 
>   plugins/subversion/svnblamejob.cpp 05fb849c26fde70eb8c08c7226313d904dc186af 
>   plugins/subversion/svnblamejob_p.h 1a1e22a3ec7be4c474a53375888688ecb0c49b8d 
>   plugins/subversion/svncatjob.h 55e6bda01ae5b705e43871374e6a97edf64069f5 
>   language/duchain/duchain.h 173cdabd3d2efb193b7a1acf2b860d5488db6f9e 
>   plugins/subversion/svninfojob.h 774f40797b61c3000249c6f05a8a5af4557d62a8 
>   plugins/subversion/svninfojob.cpp dbd923caed34f2f2162baf937e43e546d42e3419 
>   plugins/subversion/svninfojob_p.h 8831f4eddaffb1ff791ba9fce88290a72fe403fc 
>   plugins/subversion/svnlocationwidget.cpp 25aa431ce95013882ad5c401b91149de71460e32 
>   plugins/subversion/svnlogjob.h a762a9999f5d27900b48095ed90d99690e02b724 
>   plugins/subversion/svnlogjob.cpp 051090fdbe6fadb47fbf9fd3ecd1ac1828a1c0da 
>   plugins/subversion/svnlogjob_p.h c254889d1b97eb0e819669d09f53efb2868640b9 
>   plugins/subversion/svnmovejob.h 4c14bfeabfce46f112c30b8e1d15389cdc1c52c5 
>   plugins/subversion/svnmovejob.cpp e6e1d5707d5e3899fed89215a65be180152777fc 
>   plugins/subversion/svnmovejob_p.h 897dfc3825ded54ddda55324abe026a66526cf44 
>   plugins/subversion/svnmovewidgets.h fb020ab042ea07f30b95fa232d862209cd96b3c9 
>   plugins/subversion/svnmovewidgets.cpp 443268bb82108672bd9daeb34ce74cae3f26de7b 
>   plugins/subversion/svnremovejob.h 09a75459141b99575c2f8cab2e1cd62eb3e63a41 
>   plugins/subversion/svnremovejob.cpp 81a69dcd6f7f9ca3138794b99efdc9223b394d1d 
>   plugins/subversion/svnremovejob_p.h c9dfa3451dd5827c0121784c8c2d22e102230214 
>   plugins/subversion/svnrevertjob.h 9f537f8a090c6c6d1335ac31b120f1e82d8110eb 
>   plugins/subversion/svnrevertjob.cpp 991a3d62da270bf5dff9c42805485bd31538b79a 
>   plugins/subversion/svnrevertjob_p.h 404f1ecbfa059db23f19f585e68ba7822124f4a1 
>   plugins/subversion/svnrevertwidgets.h 8c9019e239bb50dec5becf734447ac87301c974e 
>   plugins/subversion/svnrevertwidgets.cpp dab38dd42e7d52adc3d96a6b69f40b91a14ae6d6 
>   plugins/subversion/svnstatusjob.h 549990b02490d4d18f5bae20e49bdadf6efc4513 
>   plugins/subversion/svnstatusjob.cpp e9af2ce0d3771efc7c58561fdb3081628b4362d8 
>   plugins/subversion/svnstatusjob_p.h 6d8789efac54e178c16596fc37679e027fcbfb84 
>   plugins/subversion/svnstatuswidgets.h b1088a577b60d668b7b365386b3ae50c23426186 
>   plugins/subversion/svnstatuswidgets.cpp 7e02d5893050f05c02cd2b0a72303a9106ec4838 
>   plugins/subversion/svnupdatejob.h 8a283ac280de20a16d1569803275892c2d18c11e 
>   plugins/subversion/svnupdatejob.cpp e7eb475935c544c2e095ae356b08a7f147217424 
>   plugins/subversion/svnupdatejob_p.h e0d388628f0831d3f1e83f21d2be8ff5317bb669 
>   plugins/subversion/svnupdatewidget.cpp 802d102cc367ebe6dba445c4fabadec285db30ea 
>   plugins/subversion/tests/svnimport.cpp a60455bc9d64e7eeffe21b892f728cbe6cd6da09 
>   plugins/subversion/tests/svnrecursiveadd.cpp bcd5cf253d59da2207f2479c076b98741d1e0476 
>   plugins/switchtobuddy/switchtobuddyplugin.h 16adcdeb5c43782f5a8085a72ce3c6b81c0b13b0 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp bad7dbba8c56c87ce23a5ea5b513ca30160c0ecf 
>   plugins/templatemanager/templatepage.cpp 888b420936f9055cf152370c9baf7bf2f7266ae8 
>   plugins/testview/testview.cpp 6510a906440f3e3874ab7cc9021c280b54055a4b 
>   plugins/vcschangesview/vcschangesview.h 83317b9a4bb3a5d7119111872234a411c9fd32e8 
>   plugins/vcschangesview/vcschangesview.cpp 11764ffae7a86f2dd12925535fa4749bda8e0db4 
>   plugins/vcschangesview/vcschangesviewplugin.h 6fc3d7876c793260b20e912ba7edef624e79b057 
>   plugins/vcschangesview/vcschangesviewplugin.cpp 465635fbdd7ab10ca1b35a9d506a6336e0e5a388 
>   plugins/welcomepage/sessionsmodel.cpp cd8e77dcd0be2a517f48cd9c77b431c5f9ff69d2 
>   plugins/welcomepage/welcomepagedocument.h 443f57af8d390696448e2a0ad9bd7fde5227e7b7 
>   plugins/welcomepage/welcomepagedocument.cpp ddea7e1bf0a416b3f4069c0307e6981328eb9c9f 
>   plugins/welcomepage/welcomepageplugin.cpp d24317e7767600d2774972ace8a4f1f708c565d1 
>   project/abstractfilemanagerplugin.cpp 94331e9a916721850a4df6d990d9e7f1953e9661 
>   project/helper.h ac4dbb02d779f7926122de5ab5c2a856b4a1b419 
>   project/helper.cpp 21f0261351fcacaaeba2c94fd33cfe30aacd4c29 
>   project/projectbuildsetmodel.cpp d44a6b1658f6083cda900d9275ef1a9b98c9a02f 
>   project/projectconfigskeleton.h f12eaf2bd90f4d490ab74af575976c46a92bf71b 
>   project/projectmodel.h 5d77958b08d288a79e9f23bf4d248c3cb3945f7d 
>   project/tests/projectmodelperformancetest.cpp 9d8476caef837ac098c1cef4862f85eff6613a5a 
>   project/tests/test_projectmodel.cpp 70c60da797798cf004817e5a1080b00569c83013 
>   serialization/indexedstring.h 182e4b51d37951af517639cd269af5666a23837c 
>   serialization/indexedstring.cpp e7786e7f2c38eff3aca744c526ef9c1742c3a334 
>   serialization/tests/serialization/tst_indexedstring.cpp 30488807e64a5ff522f3b60a6e2cc1b0ddec70d4 
>   shell/debugcontroller.cpp d27aee5bbeb1ab44e8e0c321259bf6b134a83b82 
>   shell/documentcontroller.h c18c4b47de3fe5bed2e3210fbbf952ba85a95a2e 
>   shell/documentcontroller.cpp d5e7c3b1c58cc389e1c9fb887e24c5a745efe73a 
>   shell/languagecontroller.h 57a617cc44c0915e8abc4556f1373f09d9693451 
>   shell/languagecontroller.cpp 6dbc805b2ce6815b4c374ec6868f01e42526b6bc 
>   shell/mainwindow.cpp 6741a16a42958161ce0d5c0239fc580838648da3 
>   shell/openprojectdialog.h 7aa124fcab1dc9962741593e1dc9af68b6794830 
>   shell/openprojectdialog.cpp 4301304f288a88e354e235e178fcd2968f99099b 
>   shell/openprojectpage.h 4732294413667dcdaef8f0b12cb4261e3124f8a1 
>   shell/openprojectpage.cpp 33fb333e4d03259cfc31e93151f09887169e0f5e 
>   shell/partcontroller.h 75ad6bb9256284c3ca79f703d95b4b12f0455d9e 
>   shell/partcontroller.cpp edf476dc1e1a83a408d83d84c46528c1f8dab023 
>   shell/partdocument.h adb3f9bc1ee4b8e96803f2a1871533d01c2bcbd0 
>   shell/partdocument.cpp 8d2fdf931eaf770920ddb56f5dd04645910f6781 
>   shell/plugincontroller.h 956f641696cd02fb5479ad2f4560c49cc69ff42a 
>   shell/project.h 59aac113fcfe30b4429313c1dae4352b1e8a8c1f 
>   shell/project.cpp 1fbd904f8619debdf0bebd6759fea1fbbe846925 
>   shell/projectcontroller.h a3f827b6890d7254a6b1630709602a613657fb40 
>   shell/projectcontroller.cpp 1677e01a10d45c546a562f780cd37a7d73709a85 
>   shell/projectinfopage.h 8f6cd0eebc46b18ec5bfb3ef42889605720c10b6 
>   shell/projectsourcepage.h 261632e63abe5cd57cb3b4723726450470051841 
>   shell/projectsourcepage.cpp 5769e4a49c2772443744b2bec48bb48e6a655904 
>   shell/savedialog.cpp 531a8749e4a3d7a43113d7b335d323485b941be6 
>   shell/session.h 64a1e77e0b083c0735eef52bcb127a9bac0f0843 
>   shell/session.cpp b779a791fb7bcb748d9cea93ccd8bcc202d89d2a 
>   shell/sessioncontroller.cpp 4d96aa44050396e18bedf3bf13bde9f08ea58293 
>   shell/settings/bgpreferences.h 277917a4e96db6177307ad233efbd9a5624ff595 
>   shell/settings/ccpreferences.h f83f9e2c7c21f30d9181d0a65e716d906e0ec026 
>   shell/settings/editstyledialog.cpp ecff30a03699b8e795ba36a39f2db7c5333d0c09 
>   shell/settings/environmentpreferences.h 88813d912b44abf40d3049ad9f9eb4cf4eeb463e 
>   shell/settings/pluginpreferences.h af48c5332b626ac56b44a442ee6f2811cbf3256b 
>   shell/settings/projectpreferences.h b34a506ef7b1b1ac91ad4a9b23dc28ec029f08c0 
>   shell/settings/sourceformattersettings.cpp 31d5efec5f4512eb6b9a06453038df8f0b89849d 
>   shell/sourceformattercontroller.h a45008c9b90d0d6dd8c3910acb9ed3f3d88be0db 
>   shell/sourceformattercontroller.cpp 0ad0ffa4dea45c5be7dec0037262074637cf3404 
>   shell/testcontroller.cpp baa1fa9ef0d1acd170bdab494c2a3b885af881ce 
>   shell/tests/test_documentcontroller.h 4530a2d7258502e2f7c2d77970421d99eb0f3647 
>   shell/tests/test_documentcontroller.cpp 6f3fb01efb6182721cea5afd7c70359d012fc5cc 
>   shell/tests/test_projectcontroller.cpp 489b7960ba4ed5889c379432f64325f89fe16149 
>   shell/tests/test_shellbuddy.cpp 76c941e0d47ca87a43e9c5a0dc214701ba13bae5 
>   shell/textdocument.h 2b7932cc1b429666232b8a66686c44ee9df25958 
>   shell/textdocument.cpp 2e3722db1776a7d7063573e67c3adc3549c35be1 
>   shell/workingsets/workingsettooltipwidget.cpp cbb274ef4b67e9b6204ccf5dd8441b7b5502c985 
>   sublime/container.cpp 304f1871801898021f6d500cd38556b5b281c56c 
>   sublime/examples/example1main.cpp e168333da1cb379a0dc507d037f851913227e9e7 
>   sublime/examples/example2.cpp 679d1dcbca0348e044cbbb02bcc074223954451d 
>   sublime/tests/test_areaoperation.cpp ef545329b42ae77820541431ec7dc53295f1f869 
>   sublime/tests/test_areawalker.cpp 07777c032241942d6d9052bd9731255d7628030a 
>   sublime/tests/test_controller.cpp d377cf0ffbff79a18267cb05395eb97e4f472392 
>   sublime/tests/test_document.cpp 87b1ac06d6489e0f1ecd55525762badeda72704b 
>   sublime/tests/test_view.cpp 8e415f614a35d5e9eb56f9f8897c4c421bd915ed 
>   sublime/urldocument.h 29e686b505095141bb3d746d2e5f8f6d3beab7a8 
>   sublime/urldocument.cpp f8ebcec212ab67adde9d6158f9cdc2eec4f5f77b 
>   tests/testcore.cpp a3e4c945b265c9bd1de440d8059862d62b68276e 
>   util/duchainify/main.h 14b3fad0c228047033f24f0d11e26a0d26434f50 
>   util/duchainify/main.cpp d7a8eaaf6ac847becb09a209bbaeb4a69927ec89 
>   vcs/dvcs/dvcsjob.h f7010fc4c5e3e6f599bc12e5c19319bac8c5e63d 
>   vcs/dvcs/dvcsjob.cpp d2bd90e3b9cbf54ba0cb2ea73531082732f9f112 
>   vcs/dvcs/dvcsplugin.h 3d7e3a44675aa36268d6bff4090c66c7b0e5e06a 
>   vcs/dvcs/dvcsplugin.cpp a273653edb393984b9e836f05b7ca47ed348bc90 
>   vcs/dvcs/tests/test_dvcsjob.cpp 98d7ac46bd86e0dc5ac28d5168036fca716c9b96 
>   vcs/interfaces/ibasicversioncontrol.h de3ef6ebfa901f4a89cdf67b26dbc908cd0223e2 
>   vcs/interfaces/ibasicversioncontrol.cpp 02e06a93cd41eec9a46634bf4b3b694744dde038 
>   vcs/interfaces/ibranchingversioncontrol.h 4bddc46b42db25628966edd6967b24a28d6c3da0 
>   vcs/interfaces/ibrowsableversioncontrol.h 807b135b53355da11e8524a3c5b76511e1961369 
>   vcs/interfaces/icentralizedversioncontrol.h 49a6193013e48fe8775de5c7255331d1ae2d1f3d 
>   vcs/interfaces/icontentawareversioncontrol.h a5643810a4840aab0672e7bb22ce334a32f3d1d4 
>   vcs/interfaces/idistributedversioncontrol.h b36f74323fd1215520ee9412f2558116ba3d0fb6 
>   vcs/interfaces/ipatchdocument.h af8eb9a944656fbd474d559d5bf8473930133c1f 
>   vcs/interfaces/ipatchsource.h f8fb245d02e4f835d8a324cd3d091ba1a29abcff 
>   vcs/interfaces/ipatchsource.cpp a4a1a6477bdb00ff80b4d5f29da7b7287f5e5b03 
>   vcs/models/brancheslistmodel.h dae5fc8c3602be8bb53d03544c789c1321560986 
>   vcs/models/brancheslistmodel.cpp f2fbe0dda21deff587575ba4d350762037449529 
>   vcs/models/projectchangesmodel.h ae6eec5ae26a49fa492dbd9ddf04fdb3e85c7d43 
>   vcs/models/projectchangesmodel.cpp 1308b8b12208ab94f0c536af8ee77a91966061bb 
>   vcs/models/tests/test_models.cpp fce698135bb32d58836fa0d747593f2a3c2dfc07 
>   vcs/models/vcsannotationmodel.h 0cab18bfc44cc3b127cd47b9863f97e2719f7bde 
>   vcs/models/vcsannotationmodel.cpp 54d7e014298171d3e311f16cac019ebb950406dc 
>   vcs/models/vcseventmodel.h 4b2d0871b5b428ec02ca5f4118e44d5de4ce907f 
>   vcs/models/vcseventmodel.cpp 4a93778f859b50f540176776764f9ab5a99aa198 
>   vcs/models/vcsfilechangesmodel.h e740daaa81635b4d298cd5637d5bff01838f4abc 
>   vcs/models/vcsfilechangesmodel.cpp 9e29b0bd94cef1a791c67d84de6446b2d803b60c 
>   vcs/vcsannotation.h 0956904dc94b8200f04ea4710d5b9a1526761207 
>   vcs/vcsannotation.cpp 235206b3312bb4cd93bdc15f7d7b254d5ccfa756 
>   vcs/vcsdiff.h 573ec1b92262019291acaf3e0f65bea9bc079716 
>   vcs/vcsdiff.cpp 01eb73cfd496d86bb7984f62ed084304e7bcc195 
>   vcs/vcsjob.h c1b7100171ce1bd6cba4311bb174a191a163d2c9 
>   vcs/vcslocation.h 4de490bd522c1f7245e1bbdb9cea689ceeadad5a 
>   vcs/vcslocation.cpp 55729595c7915dbd79df0c8805176333fb8332e1 
>   vcs/vcspluginhelper.h 7e660163225181869d7f9dffe83285de6e94dfdc 
>   vcs/vcspluginhelper.cpp e1dffa82bd4ab7f28e91c811dfe9242c3e6dca96 
>   vcs/vcsstatusinfo.h c5eecc01fe598d282fa5ba2420263c45d618bad9 
>   vcs/vcsstatusinfo.cpp 0f8be97ee796c801a6b0bac7d6f742ac62733850 
>   vcs/widgets/standardvcslocationwidget.h 68b73a6eab778debb93017b405241a2fb018adc2 
>   vcs/widgets/standardvcslocationwidget.cpp 91a538a4fb3501200507f10e008c2c9dfd9fd2e2 
>   vcs/widgets/vcscommitdialog.h e2df40bcd2ae7edc58b5e15706a630ed37eb5cd8 
>   vcs/widgets/vcsdiffpatchsources.h ea2799c890083fd29c5bb661fcd639805e7ca235 
>   vcs/widgets/vcsdiffpatchsources.cpp 4fce7e486f6e97f59f2b11edd08abad69fa6c280 
>   vcs/widgets/vcseventwidget.h b6ef012dc4397a16f1b3a875268df865104950e7 
>   vcs/widgets/vcseventwidget.cpp 69aa17eac3dd25e9984dc5e09ab25dea647adf77 
>   vcs/widgets/vcsimportmetadatawidget.h 844b397b80ae0d074113e017fe95ebcfd7b456a2 
>   language/duchain/duchain.cpp 4387ae8808a41bb2c67122cec59331bf89cd7f20 
>   language/duchain/duchainutils.h 9d925f3efd1b7164f973ce894a74698c8a5f3157 
>   language/duchain/duchainutils.cpp 9d6a8b792b7d520ffdb24a588687d1c9e9ce50ac 
>   language/duchain/dumpdotgraph.h 22a379e278080a7ec2a6754fa5cea5bcb6ab277a 
>   language/duchain/dumpdotgraph.cpp 6a1acc1a0a4504fb9f14ada4ce3d79b91576859e 
>   language/duchain/navigation/abstractdeclarationnavigationcontext.cpp b1f88c41236fe36750bd9fd240bcaa50faf9c2e7 
>   language/duchain/navigation/abstractincludenavigationcontext.cpp 6477b9c9dfaeabf2d446080dfd54bbea3f6c0419 
>   language/duchain/navigation/abstractnavigationcontext.cpp 05143a1b3095e11e998e199cd6426db0339bf167 
>   language/duchain/navigation/navigationaction.h c64f1a6d6b48d42d4baa92ed75b30902268f2304 
>   language/duchain/navigation/useswidget.cpp e0ff561db0b2cca24d7174b52f4cbd791592ee09 
>   language/interfaces/codecontext.cpp f3bec651f71ad803d6de071e2a2fbbac039ae30e 
>   language/interfaces/editorcontext.h 4e10c69cbf79fd4ed73d720fee3b0859386711b1 
>   language/interfaces/editorcontext.cpp 8e3e2f723734c67643e6cc11b45e3558dbd986ef 
>   language/interfaces/icodecompletion.h f59f27765765a8ba31f3b0fc552a460877c48d37 
>   language/interfaces/icreateclasshelper.h 28b86985d05366fd824edc10783e1052dcdad111 
>   language/interfaces/ilanguagesupport.h c4d3e2ccc7b7b8c840da28ab0e82ecfc3877b929 
>   language/interfaces/ilanguagesupport.cpp 66eda8655a3f800dff7d7666fcefa3af47bd8518 
>   language/interfaces/iquickopen.h a2883b544c45a410acbaba597bb26911571cbccd 
>   language/interfaces/quickopendataprovider.h 6fccb6c0251853ad914d2c10cc719c4b016a7e8f 
>   language/util/includeitem.h 44f691edfee4af3d43c9212717cb686c82e29cb5 
>   language/util/includeitem.cpp 5a4f0a33ace9a819faef24ba888e15716f7c14a6 
>   outputview/filtereditem.h 925cb833bb81962be2ce13d9f422bedf3fe6332a 
>   outputview/outputexecutejob.h 61b6d05f7c5c9e27a306d5f5868adea4d95bbaa1 
>   outputview/outputexecutejob.cpp 5551f9af7a2896476f6452bdce79fe34103c1a73 
>   outputview/outputfilteringstrategies.h 0f63cd532652b04d2a6b18b45efbcb81ced5ee6b 
>   outputview/outputfilteringstrategies.cpp f82420f8e1ebbb97507dbeb32f37c5629bf0f826 
>   outputview/outputmodel.h fedeeec5b318f4e57ae681111fd31ecc470f3188 
>   outputview/outputmodel.cpp 667f33d5e0f6f7e2cda7821afda647edf3940f73 
>   outputview/tests/filteringstrategytest.cpp f6c7f7eedcdb3c85d230f37f54ef2de2cdf4a1d7 
>   outputview/tests/outputmodeltest.cpp 3851670a306311e60ef0df3a630efd19623bbaec 
>   outputview/tests/testlinebuilderfunctions.h 653e484f6e7f9d1340515af5dda031271e09bb54 
>   plugins/appwizard/appwizarddialog.h 5b43a2053a83fb0b25abe84fc7f907534537bc30 
>   plugins/appwizard/appwizardplugin.h 64d6144e723bd982deab0be1777c5eaa54ba3d47 
>   plugins/appwizard/appwizardplugin.cpp e14b140e9ba4fb195c3d2df214cfc01bb3248a21 
>   plugins/appwizard/projectselectionpage.h fd6ad1b8f9a0f421f9f5348efb59ce98b8c329df 
>   plugins/appwizard/projectselectionpage.cpp b43b9152730b11354a50aff60e1dbdc6afbaf1e7 
>   plugins/appwizard/projecttemplatesmodel.cpp 717c99fa2e96bb081831ef9becf882402215d0fc 
>   plugins/appwizard/projectvcspage.h 836f3d1431d38007e30c2107a90c7d3805a09086 
>   plugins/appwizard/projectvcspage.cpp 520a87ac0997de2e5fced8a334f5e21955bf48e5 
>   plugins/bazaar/bazaarplugin.h 6f0a3eb2e8f34f7a8c970a309e1b965511b2e8a3 
>   plugins/bazaar/bazaarplugin.cpp c94612cb41453295d16a9500586a256606c6fdc5 
>   plugins/bazaar/bazaarutils.h c92532962e18a7cfcfe9d01b6e4e2b69db10c27f 
>   plugins/bazaar/bazaarutils.cpp 525f96f0f5b3953533d31331e10ee07b173c185a 
>   plugins/bazaar/bzrannotatejob.h dbc5b448c7eafc6db602f8e63d11e9b324c0a2e0 
>   plugins/bazaar/bzrannotatejob.cpp 438640a311cf895682842de218190a866dcaf073 
>   plugins/bazaar/copyjob.h 57630548021675b1d308271965868de9daa7d0f9 
>   plugins/bazaar/copyjob.cpp e3cdd37601a280d3202bec2d366bbe81edafd9fc 
>   plugins/bazaar/diffjob.h edf4b78f40772342ad6911689a1d416c5ac95df4 
>   plugins/bazaar/diffjob.cpp c64902f6e8ff9301d8dce596f5999b01ed15a1e4 
>   plugins/bazaar/tests/test_bazaar.cpp 2a1e49a294f814ac0192f8727d9b1e31daa2fe2d 
>   plugins/classbrowser/classbrowserplugin.cpp 13416c6325d8e282df492e4eee20ef4fbfca6f9e 
>   plugins/codeutils/codeutilsplugin.cpp bf21766fad6a5cb634604bb00c91dd66c3f83425 
>   plugins/codeutils/tests/testgenerationtest.h 9cc01f86e26da2003e4538beef9a1b0304129a05 
>   plugins/codeutils/tests/testgenerationtest.cpp 80d6a52f63aef326a5eebb5b516f30aee99f1b4a 
>   plugins/contextbrowser/browsemanager.cpp 8d229caf5e7cf00825c62d894484d8daad11e635 
>   plugins/contextbrowser/contextbrowser.h da89de05f5143b42b8b16a7dd6ee1e508d3f313a 
>   plugins/contextbrowser/contextbrowser.cpp 155da65df82d538f5cf443e782c4bd6cd25a278e 
>   plugins/cvs/checkoutdialog.h f1ddba0de8dc81fe8f13fff8a6313c63f490eabf 
>   plugins/cvs/cvsannotatejob.cpp a19d2af5160ab6d00b2551fb64e72b24c46a959a 
>   plugins/cvs/cvsplugin.h feebcef7fc14cd24e2b6bdb7ffbd077f3e4a6da2 
>   plugins/cvs/cvsplugin.cpp efd763415812553a91b8a2827a447a407a8f73ce 
>   plugins/cvs/cvsproxy.h 2c33c1fd00c0569a40191916e1a1354d8b4f3a99 
>   plugins/cvs/cvsproxy.cpp 23f7956d3b80e7923321e5e479248891a06232d0 
>   plugins/cvs/cvsstatusjob.cpp 425e349186517eccf6a686b5529ab000eeaa3c12 
>   plugins/cvs/importdialog.h 8d15a5a343c63c1d7551d12a46ba70c5a0ba0802 
>   plugins/cvs/importdialog.cpp 284bf2aef4b425d4902dcf05423be529608c0782 
>   plugins/cvs/tests/cvstest.cpp cd153da4f750327f105e3a63895eb6dc81129532 
>   plugins/dashboard/dashboarddocument.h 1d8f826b94b5c9bd8c1dde2e5f1510025033fd23 
>   plugins/dashboard/dashboardview.cpp 11233433fb71c804a298ae3947f80cf48504cc2b 
>   plugins/dashboard/kdevprojectdashboard.cpp e08b4b4e86265413cda67da0b932763f0d258dd3 
>   plugins/dashboard/plasmoids/projectfileplasmoid/projectfileelement.cpp af8efb9e1890a00da8ba02d85f6dc8affacdaef6 
>   plugins/documentview/kdevdocumentmodel.h 2a4c2232879553130d525dd6bb1c7d9ed92a22fc 
>   plugins/documentview/kdevdocumentmodel.cpp 65fd448b06b399c9f43935d5ec4d5cde9532c023 
>   plugins/documentview/kdevdocumentview.h 87b91e129bd23783d0a7bafe6f62ac90e4a975fb 
>   plugins/documentview/kdevdocumentview.cpp e8754e418cbbee998cfb8c43552e02935b0deceb 
>   plugins/documentview/settings/preferences.h 1f6e7f66adb27fd48d004e8e56a5d2929f1b6b32 
>   plugins/execute/executeplugin.h acf9d51765a18072ce6949f3e3fd2af692581585 
>   plugins/execute/executeplugin.cpp 6a1c30f1792cb094f2f06ca03d64981ed90f97cd 
>   plugins/execute/iexecuteplugin.h 3ac3a37102a3715b67e647fd0cba257b85e71016 
>   plugins/execute/nativeappconfig.h de16535acad5c87834ce9da5ed626b2d0913882a 
>   plugins/execute/nativeappconfig.cpp ab406e3bb71a53a122d2c9566b0fb8c958b15db7 
>   plugins/execute/nativeappjob.cpp 06f58112f943d4c790e34f6c0b70402ff71a521d 
>   plugins/executescript/executescriptplugin.h dd3e94b096e86987e255bb93e5e082e3ed26a9ca 
>   plugins/executescript/executescriptplugin.cpp a170439a20e85fa660ecd705f1dd0022bd1b7625 
>   plugins/executescript/iexecutescriptplugin.h 327bd0f91139b731c81b737c07f9f70505118c20 
>   plugins/executescript/scriptappconfig.h 5a293b96719939e8198338b73db560154c906a77 
>   plugins/executescript/scriptappconfig.cpp e4e7fbdb13d76ddb524a80dd2ff45c1a30e8ffb4 
>   plugins/executescript/scriptappjob.cpp 718beb1414dd3e57440793ed40e6d0c3fbe6ae10 
>   plugins/externalscript/externalscriptjob.h 4bcfb452be71fb6d760c207a79e4d073c692f30d 
>   plugins/externalscript/externalscriptjob.cpp aaef1b3e7ad0b3cc10bfc122ff7bfed54158479a 
>   plugins/externalscript/externalscriptplugin.h 05f213cb16599cd807939b44376c12529db8969b 
>   plugins/externalscript/externalscriptplugin.cpp 3d5c8fa3c8c748e5d64c31079c1848bbd2da851e 
>   plugins/filemanager/bookmarkhandler.h 59b6bba87485625517068c9fb48fc0b6b1089ae2 
>   plugins/filemanager/bookmarkhandler.cpp 92feb317770f265e669c94091d60f63bd3c16630 
>   plugins/filemanager/filemanager.cpp 160178b204db47bbcf383c097bb12fb10351a4a6 
>   plugins/filetemplates/defaultcreateclasshelper.h bac36979c39faa93631b341f3b595fd215048c3a 
>   plugins/filetemplates/defaultcreateclasshelper.cpp ba45667f49ad12c24e36557c1899f2a98ce9c48d 
>   plugins/filetemplates/filetemplatesplugin.h 3ba2af8ac9cd7573465b0877a732ce5f6cd8a018 
>   plugins/filetemplates/filetemplatesplugin.cpp 4fa5a2cb1b65d2822505020c7d7e378d58fec3d8 
>   plugins/filetemplates/main.cpp a4e57f54d1910741f325652fb34ec0ca2cc95b84 
>   plugins/filetemplates/outputpage.h 5cf5b1e36f3d9dbe3bd7db03dec5d930253330dc 
>   plugins/filetemplates/outputpage.cpp f479fd43832679326bd7b6972dac443b5b8d825c 
>   plugins/filetemplates/templateclassassistant.h c11e7e037fd1dc951e04fe5b8ee6923cf83e44dc 
>   plugins/filetemplates/templateclassassistant.cpp 4e8604513d48f3170bc4cdf91578a58722e1cfa1 
>   plugins/filetemplates/templateselectionpage.cpp b67e353bc3cb78f2f094e7da12fbfb7e86a878f5 
>   plugins/genericprojectmanager/test/reloadtest.cpp e09c238537af15c7217d70a09d117c82b4d03bdd 
>   plugins/git/gitjob.h fec3347ac342e382510bc754973c37250c49292a 
>   plugins/git/gitplugin.h e93042378d9c24824df087d74b42516e0da4959a 
>   plugins/git/gitplugin.cpp 9fe04a0c7485371959a476bea0168aba69705c9c 
>   plugins/git/stashpatchsource.h 2ea502236ff688faa1f61036e252002d9818714e 
>   plugins/git/stashpatchsource.cpp a5eebbde7d9fc306e05c119c6621abf57c3688f0 
>   plugins/git/tests/test_git.cpp a35c61ce4976a4f551198d251d0d3c36c1dff871 
>   plugins/grepview/grepdialog.h 726ffbecd7012f29e405ac209e3121f6e086ca2d 
>   plugins/grepview/grepdialog.cpp 6034191c4257fdbb6a2d6311f07503bb3931f0e2 
>   plugins/grepview/grepfindthread.h 8c5d5a2e04ec03673d3d50ac0e3c0760682af006 
>   plugins/grepview/grepfindthread.cpp 19286f392a2395caab4674ece57d61561ab7e3ec 
>   plugins/grepview/grepjob.h 4bf87f55ddfe21eab6418169d122a5410e0cfdeb 
>   plugins/grepview/grepjob.cpp 5eb3493eba67da8dbc3c545679ee02c7eb32a8f8 
>   plugins/grepview/grepoutputmodel.cpp f35c9dc735bb08522cb8884e5c89f8a437dbc31a 
>   plugins/grepview/tests/test_findreplace.cpp c0c20ae751fc4045db13fe1acf14b6847748fe60 
>   plugins/konsole/kdevkonsoleview.h 3652497295fb3dc59c82e9b344e5625566992b9a 
>   plugins/konsole/kdevkonsoleview.cpp 248a4041a0f48814c33f026b422593b0fe04a695 
>   plugins/openwith/iopenwith.h 95f119c9c1ef3eec5ca63ec9cfa861e82b7538a0 
>   plugins/openwith/openwithplugin.h 1a3c7c701fdda28c5a3635e1d8c930ba601243f4 
>   plugins/openwith/openwithplugin.cpp b80916232ab451fe0cdcbae3c4c2283444270318 
>   plugins/pastebin/pastebinplugin.cpp 1a53d744ea28fb3b2f60c98b6a6b3a820aacf3b3 
>   plugins/patchreview/localpatchsource.h 20f4b7ee5cddefac810b26ae7aeaeb4de6cefc9e 
>   plugins/patchreview/localpatchsource.cpp 2f590cb70c3de69cb5a72b6f1dd68584d73c4ff2 
>   plugins/patchreview/patchreview.h 59761a787ac810bd6230bc57bc7c67fe652165ba 
>   plugins/patchreview/patchreview.cpp 0195d372d59571fd8714988bbea73d1ac87c9783 
>   plugins/patchreview/patchreviewtoolview.h 26d6a977f9b9cc487c4a5df0953dd00a81c4edee 
>   plugins/patchreview/patchreviewtoolview.cpp 57b46070cdc142799b5b81ca0efd22bd129ff99b 
>   plugins/patchreview/standardpatchexport.cpp 8f656e5f8bbdc5ed5b61e763ae6b30b5a9366ef9 
>   plugins/problemreporter/problemmodel.h edf8fbb99db9cd4efe9b2c8815c3fca435f9370e 
>   plugins/problemreporter/problemmodel.cpp 9e0758a03a9d84481ceca85e65141fd840ab7ddb 
>   plugins/problemreporter/problemreporterplugin.cpp 2c44cca3bd76e23333a90f6799042e989e27cb82 
>   interfaces/context.h 835affae8994cdbd1299392162f317d4ed66df98 
>   interfaces/context.cpp cb22b05ec5152fd515bff683a47edc747ac8bb07 
>   interfaces/ibuddydocumentfinder.h f15eab1bbc50904f463fe107919c70e1f6d454e3 
>   interfaces/ibuddydocumentfinder.cpp 56511d5ac5e638e99df79bc47de7b12bd859f3a6 
>   interfaces/idocument.h a89100f19ecb76589e647bd344d921e704aa1629 
>   interfaces/idocumentcontroller.h 23cc9fdf9a7155bc34b4fa760c22fce1b5f85f41 
>   interfaces/idocumentcontroller.cpp 6029fb0b8b245ecc845a62c9a0c4c91f46a8724a 
>   interfaces/ilanguage.h 95da8189e08ba643131413e1831ec4018f2ffb5c 
>   interfaces/ilanguagecheck.h 9c3af25e4fecb45f90d07c8977dc179829f093d8 
>   interfaces/ilanguagecontroller.h 4f3a63462c14ce64b0f62ae354fe6eb383b244c3 
>   interfaces/iplugincontroller.h 0a8bc44593e513882bb4bffc743e1195f374ca46 
>   interfaces/iprojectcontroller.h 3ec061e8872238209b329bc73be8412e62155f44 
>   interfaces/iprojectprovider.h 8af82507c2933cbc2ba37186858ae5557a6d4eb7 
>   interfaces/isession.h a5a80772a6a9cd7140bcb6f2d571e7b92125cbac 
>   interfaces/isourceformatter.h 3642c0e69c3bdf9dc5d45c7b62ddcf2a6385b09b 
>   interfaces/isourceformattercontroller.h 2163ab8186c605a397869f4f61e52b6b321b381c 
>   interfaces/itestsuite.h f91a2450610d2a0a8bc8b9b48d3bef16469690f5 
>   interfaces/launchconfigurationtype.h c8f53c0ae4a986d7caed5f5f093e7089905a533c 
>   language/codecompletion/codecompletionmodel.cpp d95e8eddb7b23e59ae368bff27c72ec0862c74aa 
>   language/codegen/applychangeswidget.cpp 1c49dea9f3b76226e62387b58e6e0ecc389c7333 
>   language/assistant/renamefileaction.cpp 2585510de58f25662db8245f5b4b9888d37be04d 
>   language/backgroundparser/backgroundparser.cpp fcd2ca6faee6031f01a9aebabf382e62da87c441 
>   language/backgroundparser/parsejob.h c3029304daa1df987f4f67f0e612e6c10f8f86f7 
>   language/backgroundparser/tests/test_backgroundparser.h d2f43a19a1ae7ae8c12f1e3f2cf659c4e892500a 
>   language/backgroundparser/tests/test_backgroundparser.cpp 29ec4db9f8510cd9dcb59047c7d4a58c2af8fd40 
>   language/codecompletion/codecompletionmodel.h c495c3a5479ad05230895b52c984ab74959d2328 
>   plugins/subversion/svncatjob.cpp 997eecb3c827e9a3ee3fb1cf657cad29390fd51c 
>   plugins/subversion/svncatwidgets.h 8dca73c22dcb66e95ea97fef7220ed844c20579e 
>   plugins/subversion/svncatwidgets.cpp 1b24eb23881c56d6d8675b9ca749837e10c1d846 
>   plugins/subversion/svncheckoutjob.h 8fae3562bd41a8196d4bc72cb8747c719273798a 
>   plugins/subversion/svncheckoutjob.cpp 9baff5cff96e1cf1e9158cf714525bf4d65a3785 
>   plugins/subversion/svncheckoutjob_p.h 3ff4908d0e15fb559be79132464d2886beb1da14 
>   plugins/subversion/svncheckoutmetadatawidget.h 5c99da247ed12594da4f6cd681e9a4456ddd1df8 
>   plugins/subversion/svncheckoutmetadatawidget.cpp 5a35f8789fdabef250d457dee0a72beef556738c 
>   plugins/subversion/svncommitjob.h a740e37541027f332454495182bbc6f1d9bcc19a 
>   plugins/subversion/svncommitjob.cpp c2534bf4afcfde9572fee2af6a52ce5381099a04 
>   plugins/subversion/svncommitjob_p.h 5afb6c065fa909a8c43620533326a6a7f56997d3 
>   plugins/subversion/svncopyjob.h 245fb15f70b718a3d0c7a7eec928a69f729ffe91 
>   plugins/subversion/svncopyjob.cpp fc5086d0f3df40149d4feb9d28c636d76ad235dc 
>   language/codegen/templateclassgenerator.cpp c13297388bff0f0aa07c98344005a567cc83641a 
>   language/codegen/templaterenderer.h 662f30ea98277ed7d217b6c6ef66243f6934359b 
>   language/codegen/templaterenderer.cpp 71cc61fef603f2c7b0f3e0d71247bff0232c97be 
>   language/codegen/templatesmodel.cpp 1f47323389148d95dc1942508da259983e6b2e56 
>   language/codegen/tests/test_templateclassgenerator.h 5a43534c97089b914ce4b88469b807f2b050cd98 
>   language/codegen/tests/test_templateclassgenerator.cpp fadd107396300f06e11f9a3ecffb31914fa944ce 
>   language/codegen/utilities.cpp 53195fd72637e11f5fc4a0586c925a5084921af6 
>   language/codegen/basicrefactoring.h c1fa0853821f46714e93f32ef4e45bc3c807b92a 
>   language/codegen/basicrefactoring.cpp e00f202b88d1625b5e15e5360d34230677be075d 
>   language/codegen/codegenerator.cpp 81894eb97be91fbcd68798885aa5d720af890ea0 
>   language/codegen/coderepresentation.cpp 5074f7d37535fc3ddf27e143cfa644d5d8edafa5 
>   language/codegen/documentchangeset.h 43e7735a1ea1f095db44c79e37fa94d14e55dcb0 
>   language/codegen/documentchangeset.cpp 1937be5eb64d32f87e574a376a41b72fb0b63a74 
>   language/codegen/templateclassgenerator.h 025d6770059868aac91d846efb44ed062d2c30ce 
>   plugins/subversion/svncopywidgets.cpp e0b7696968e8929e41217f2f13370115585da748 
>   plugins/subversion/svndiffjob.h a823d527d1dcf0d30ccc3d4c0c43ca1e55d86bf0 
>   plugins/subversion/svndiffjob.cpp 633f7e1f80a83f34ce72dc25ea20392c2f1bedfe 
>   plugins/subversion/svnimportjob.h d551b37be41cede9d45589659e4b46f251a8221c 
>   plugins/subversion/svnimportjob.cpp a40d7440919503b5ebbfa8fae4f2202ba39347c4 
>   plugins/subversion/svnimportjob_p.h 29134b3ad7268688e7d0efa880c8b2152bfe46ad 
>   plugins/subversion/svnimportmetadatawidget.h 71fc89c4b771fbc7cddbb4604ca11755f0d6df10 
>   plugins/subversion/svnimportmetadatawidget.cpp 130b6b9249f66138ff9017f5784380be6455b263 
>   plugins/subversion/svncopyjob_p.h b8a8aa75bfaf42b5eeae063cc91c0e3e2741e1ef 
>   plugins/subversion/svncopywidgets.h 2f52c27d086d800f75f3d87db3c84038f39fbbed 
>   language/assistant/renameassistant.cpp 65f53db9d4ae9abaad7c37401b3115a83e414cab 
>   language/assistant/renamefileaction.h f8515bc7a33b627f79d2e50f56e75c04ff22edcf 
> 
> Diff: https://git.reviewboard.kde.org/r/120123/diff/
> 
> 
> Testing
> -------
> 
> Compiles and some things work, but few tests does fail and I haven't found yet why so would be nice for other eyes :)
> 
> Needs to be reviewed very carefully as it's very easy to miss something. Also I haven't fully tested it.
> 
> 
> These fail due some bug here:
> 
> * test_projectcontroller
> * test_quickopen
> * test_findreplace
> * test_kdevgit
> 
> 
> Some other tests also fail, but they didn't passed previously either.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140910/aa2918f0/attachment-0001.html>

More information about the KDevelop-devel mailing list