Review Request 119938: Switch to QApplication in reviewboard test

[Dāvis Mosāns]

> On Sept. 2, 2014, 11:34 a.m., Kevin Funk wrote:
> > plugins/reviewboard/reviewboardjobs.h, line 73
> > <https://git.reviewboard.kde.org/r/119938/diff/2/?file=307713#file307713line73>
> >
> >     Not needed either, right?
> >     
> >     The 'ReviewRequest" class doesn't call this method, hence it's kind of useless to make this a protected virtual method.

Both `SubmitPatchRequest` and `NewRequest` have these and are used, so by adding them to `ReviewRequest` I thought it might be useful there in case want to do something generic without caring if it's `SubmitPatchRequest` or `NewRequest`, but anyway removed now.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65682
-----------------------------------------------------------


On Sept. 9, 2014, 3:10 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 3:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
>   plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140909/26ada64f/attachment.html>