Review Request 120104: remove 'override' keyword to make kdev-python (frameworks branch) build properly

[Laurent Navet]

> On Sept. 8, 2014, 10:04 p.m., Miquel Sabaté Solà wrote:
> > IIRC, we're targeting GCC 4.7 and Clang 3.1 (since the release of KDevelop 4.7). In these two cases this should compile just fine, so I don't know why you would want to remove that override :/
> 
> Laurent Navet wrote:
>     I have gcc 4.9.1, and it don't build with :)
> 
> Miquel Sabaté Solà wrote:
>     gcc 4.9.1 here and it builds just fine :P Are you on the last commit of KDevplatform master. Keep in mind that a recent commit [1] on KDevplatform changed the type of the first argument.
>     
>     [1] http://quickgit.kde.org/?p=kdevplatform.git&a=commit&h=cd15efed451a41ac2443812698381a8c4b88bcbe

here is the error thrown by gcc:

In file included from /home/laurent/src/kdev-python/codecompletion/context.cpp:23:0:
/home/laurent/src/kdev-python/codecompletion/items/functiondeclaration.h:44:18: erreur: ‘virtual void Python::FunctionDeclarationCompletionItem::executed(KTextEditor::View*, const KTextEditor::Range&)’ marked override, but does not override
virtual void executed(KTextEditor::View* view, const KTextEditor::Range& word) override;
             ^
In file included from /home/laurent/src/kdev-python/codecompletion/items/keyword.h:22:0,
                 from /home/laurent/src/kdev-python/codecompletion/context.cpp:21: 
/home/laurent/kdevelop4/include/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.h:52:16: attention : ‘virtual void KDevelop::NormalDeclarationCompletionItem::executed(KTextEditor::Document*, const KTextEditor::Range&)’ was hidden [-Woverloaded-virtual]
    virtual void executed(KTextEditor::Document* document, const KTextEditor::Range& word);
                 ^
In file included from /home/laurent/src/kdev-python/codecompletion/context.cpp:23:0:
/home/laurent/src/kdev-python/codecompletion/items/functiondeclaration.h:44:18: attention :   by ‘virtual void Python::FunctionDeclarationCompletionItem::executed(KTextEditor::View*, const KTextEditor::Range&)’ [-Woverloaded-virtual]
    virtual void executed(KTextEditor::View* view, const KTextEditor::Range& word) override;                   ^


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120104/#review66083
-----------------------------------------------------------


On Sept. 8, 2014, 9:47 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120104/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 9:47 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> remove 'override' keyword to make kdev-python (frameworks branch) build properly
> 
> 
> Diffs
> -----
> 
>   codecompletion/items/functiondeclaration.h 2e301a5 
> 
> Diff: https://git.reviewboard.kde.org/r/120104/diff/
> 
> 
> Testing
> -------
> 
> just build.
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140908/ea08a667/attachment.html>