Review Request 120086: Fix cursorSpellingNameRange range for out-of-line functions.

[Sergey Kalinichev]

On Sept. 7, 2014, 12:52 p.m., Sergey Kalinichev wrote:
> > I don't like ClangHelpers::cursorSpellingNameRange :).
> > 
> > The cursor kind is already selected at compile time in the caller, but here we get the kind again and do unnecessary branching (which tuduchain in all its uglyness was designed to avoid).
> > 
> > Now this would make it even more expensive by creating multiple disposible QStrings repeatedly for every cxxmethod parsed.
> > 
> > This could be optimized, but TBH I slightly prefer the incorrect clang ranges to this hackery :/

I see.
Still can't figure out what "bool SomeFoo::operatorAvailable" suppose to mean...


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120086/#review65947
-----------------------------------------------------------


On Sept. 7, 2014, 10:20 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120086/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 10:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This was accidentally broken by:
> f17866db1bc24c198e87c028065796959f6dd135
> Author: Kevin Funk <kfunk at kde.org>
> Date:   Mon Aug 4 16:53:06 2014 +0200
> 
>     Also fix ranges for operator functions
> 
> 
> Diffs
> -----
> 
>   duchain/clanghelpers.cpp fb69a66 
>   tests/files/functiondefinitiondeclarations.cpp fe4050e 
> 
> Diff: https://git.reviewboard.kde.org/r/120086/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140907/1c458252/attachment.html>