Review Request 120068: kdev-php: porting to KF5.

Miquel Sabaté Solà mikisabate at gmail.com
Sat Sep 6 17:03:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120068/
-----------------------------------------------------------

(Updated Sept. 6, 2014, 5:03 p.m.)


Review request for KDevelop, Milian Wolff and Niko Sams.


Changes
-------

Fixed some issues that Milian pointed out.


Repository: kdev-php


Description
-------

I use the kdev-php plugin at work, so I decided to port it myself. Moreover, this patch depends on the review request #120067. This port is not over though:

1. Some tests are failing.
2. The unittestprovider plugin is not linking properly.

I'll work on this in the following days, but I thought of submitting this patch to reviewboard so you guys can give me some tips and point me to some errors :)

And yes, this patch is a bit large, sorry about that ;)


Diffs (updated)
-----

  CMakeLists.txt 7387738 
  completion/CMakeLists.txt 96746d3 
  completion/codemodelitem.h 5a30852 
  completion/codemodelitem.cpp fce05ba 
  completion/context.h dc3bf74 
  completion/context.cpp 71cd035 
  parser/CMakeLists.txt 49dbb54 
  parser/main.cpp 42f2128 
  parser/parsesession.h b365a4d 
  parser/parsesession.cpp 2b11828 
  parser/php.g dd0394c 
  phplanguagesupport.h 6112646 
  phplanguagesupport.cpp aab1ba8 
  testprovider/CMakeLists.txt 95df50d 
  testprovider/phpunitprovider.cpp 0f87886 
  testprovider/testdoxdelegate.h cc2a48d 
  duchain/tests/expressionparser.cpp 17d0bbe 
  duchain/types/integraltypeextended.h 9043fd5 
  duchain/types/structuretype.h 2d80be5 
  duchain/tests/duchain.cpp 5d983d4 
  duchain/tests/duchain_multiplefiles.cpp ffd48c5 
  duchain/tests/duchaintestbase.cpp 21dec92 
  duchain/navigation/navigationwidget.h eba8be9 
  duchain/navigation/navigationwidget.cpp cf2c4f3 
  duchain/tests/CMakeLists.txt bf365ad 
  duchain/helper.h 9b55955 
  duchain/navigation/magicconstantnavigationcontext.h 1065bf5 
  duchain/navigation/magicconstantnavigationcontext.cpp 878d1f6 
  duchain/expressionevaluationresult.cpp d89f86f 
  completion/item.h e643ef0 
  completion/item.cpp accb1e2 
  completion/keyworditem.h 03a8357 
  completion/keyworditem.cpp 58314ed 
  completion/model.cpp ba7d7ca 
  completion/tests/CMakeLists.txt 2db6e35 
  completion/tests/test_completion.cpp 3bafd8b 
  completion/worker.h c45ae8c 
  duchain/CMakeLists.txt 3b40524 
  duchain/builders/declarationbuilder.cpp 9ba4b84 
  duchain/builders/typebuilder.cpp a8e7354 
  duchain/completioncodemodel.h 5ed4799 
  duchain/completioncodemodel.cpp 96b10e1 
  duchain/declarations/classdeclaration.h 59c5926 
  duchain/declarations/classmethoddeclaration.h 976a500 
  duchain/declarations/functiondeclaration.h 404624d 
  completion/implementationitem.h 6f173fc 
  completion/implementationitem.cpp d67ea54 
  completion/includefileitem.h 95282cc 
  completion/includefileitem.cpp 428547f 
  duchain/declarations/functiondeclaration.cpp 17386d9 
  duchain/declarations/namespacealiasdeclaration.h 321a2b7 
  duchain/declarations/namespacedeclaration.h c6691cc 

Diff: https://git.reviewboard.kde.org/r/120068/diff/


Testing
-------

On the works. Some tests are failing.


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140906/955ab908/attachment.html>


More information about the KDevelop-devel mailing list