Review Request 120066: Initial port to KF5.

[Milian Wolff]

> On Sept. 5, 2014, 1:05 p.m., Jonathan Schmidt-Dominé wrote:
> > Hi Milian! Regarding to Ascii: The clean way would be adding an assertion that there are only Ascii characters in include/kdev-pg-char-sets.h. I can do that.
> 
> Jonathan Schmidt-Dominé wrote:
>     kdev-css and kdev-go indeed use utf-8. But adding the assertion and using toLatin1 instead of toAscii seems most conservative. There are no other code sections relying on Qt’s Ascii support.

Can you explain what you have in mind? And as I said, I'd rather you remove more code than adding stuff. What is this whole kdev-pg-char-sets even there for? Just expect UTF8 encodings everywhere and if need be, convert to UTF8 before parsing. I'd welcome if the kdevelop-pg-qt codebase could be trimmed down to the bare minimum that is actually required from the current users of it...


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120066/#review65830
-----------------------------------------------------------


On Sept. 5, 2014, 12:21 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120066/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 12:21 p.m.)
> 
> 
> Review request for KDevelop and Jonathan Schmidt-Dominé.
> 
> 
> Repository: kdevelop-pg-qt
> 
> 
> Description
> -------
> 
> Initial port to KF5
> 
> Add .reviewboardrc file.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt 121ad3d124a7f7020c60a996248a0320d26cea9b 
>   examples/cc/CMakeLists.txt eeccf2a357197e7c59830ed808a6848d8eaa678e 
>   examples/cc/cc.g 5b8e00166fff41fdbf29d0912eabb4cb8608f6b6 
>   examples/cc/cc.ll 490ee8e8131e1781032b9d20722d02b908762b51 
>   examples/cc/cclexer.cpp cd06fa8ff99aa1377d704f07058760beb9dcc026 
>   examples/cc/main.cpp 535d7c232b83e4e1ae3cb8c4861455280fa137eb 
>   examples/cool/CMakeLists.txt 40930506aed67863099b6ffc4c40867744052ed8 
>   kdev-pg/ASFormatter.cpp 087841ce45c703659d86a70f3aa0aaddcc0e6155 
>   kdev-pg/CMakeLists.txt 57eb03be6e451c8bf021be3f8063d19f78731734 
>   tests/CMakeLists.txt bd7ced3bd49cd7e78dfa5ada48cce286965400af 
>   examples/cool/cool_io.cpp 3ff5b4ea899ffac21fed8a5c02d5dabdd77645a2 
>   examples/cool/cool_lexer.cpp d2e44eff0d8bd4cf048aac54f6a4bd84d4d2254d 
>   examples/cool/main.cpp 4dbad70993a494bd052dd3e6c4f949143c448497 
>   examples/fact/CMakeLists.txt fc30b1ca121397a3e5e1e8842506e0f8734a4f5d 
>   examples/foolisp/CMakeLists.txt a20887e81dcf5e9a8256c1c79363d63bb2c6a47b 
>   examples/php/CMakeLists.txt 44ebb93a3f241e90f1c741a16accece6647d613b 
>   examples/php/php.g 2dac2cf760cd7837dca9610c94722eabca7cda16 
>   include/kdev-pg-char-sets.h 1ac38d445176be997150a94daf457cd79ce2b2d4 
> 
> Diff: https://git.reviewboard.kde.org/r/120066/diff/
> 
> 
> Testing
> -------
> 
> not really any yet - i want to get this out quickly. Esp. regarding the Ascii and Latin1 stuff. This code became so horribly complicated... Jonathan do we really need all this stuff? Can't we simply only ever support utf8 and be done with it? Note that Ascii is not really available in Qt5 anymore, toAscii is deprecated and does the same as Latin1, but your code looks as if it does different things for both.
> 
> also, to all others, I wonder whether my cmake code is OK or not
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140906/37316184/attachment.html>