Review Request 120067: Pass a View instead of a Document in the NormalDeclarationCompletionItem::executed method.

[Miquel Sabaté Solà]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120067/
-----------------------------------------------------------

(Updated Sept. 6, 2014, 10:45 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevplatform


Description
-------

Currently we're passing a KTextEditor::Document to this method. This is not convenient because:

1. It's different from the NormalDeclarationCompletionItem::execute method, and this is the method that calls "executed" at the end.
2. Some plugins (at least kdev-php) will need it to be this way in KF5.

So, with this patch applied, both the "execute" and the "executed" methods accept the same parameters. In fact, something is telling me that "execute" once accepted a KTE::Document as the first parameter but we've changed this in KF5. Anyways, it's better to pass a KTE::View because then we can use the KTE::View::document() method if we want to get the document, but we cannot do this with views because the KTE::Document::activeView method has been removed in KF5.


Diffs
-----

  language/codecompletion/normaldeclarationcompletionitem.h e23ac21 
  language/codecompletion/normaldeclarationcompletionitem.cpp ae36934 

Diff: https://git.reviewboard.kde.org/r/120067/diff/


Testing
-------


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140906/fba53daf/attachment.html>