Review Request 120045: undefined symbol in kDebug statement (resolves to global C function on Linux)

[René J.V. Bertin]

> On Sept. 3, 2014, 10:52 a.m., Kevin Funk wrote:
> > I guess you're referring to the kde4-legacy branch, right? Because it has been fixed in master for a while already.
> > 
> > Anyway, I've cherry-picked my patch from master to the kde4-legacy branch now as well:
> > 
> > commit 32e35a13574172e860e3132820b90a1a55f241f9
> > Author: Kevin Funk <kfunk at kde.org>
> > Date:   Tue Aug 26 16:19:57 2014 +0200
> > 
> >     Make compile on OSX
> >     
> >     (cherry picked from commit 1005ecfd7bff36e9be7942ecf20cbe8c23ae1169)

Indeed I was...


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120045/#review65759
-----------------------------------------------------------


On Sept. 3, 2014, 10:15 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120045/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 10:15 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> plugins/standardoutputview/outputwidget.cpp contains a debug output statement around line 425 that attempts to print the symbol `select` . This is not a member of the class, nor a global variable as far as I could see. On linux, clang gives me a warning that I ought to prepend a & to let the expression evaluate to anything else but true but the code builds. On OS X 10.6.8 with gcc 4.8, I get a compile error about an unknown symbol.
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/outputwidget.cpp 3b12aca 
> 
> Diff: https://git.reviewboard.kde.org/r/120045/diff/
> 
> 
> Testing
> -------
> 
> Successful build on OS X.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140903/b0c6dcf7/attachment.html>