Review Request 120035: Fix 'destroyed locked mutex' warning

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120035/#review65688
-----------------------------------------------------------

Ship it!


Ah - the joy of what is the ForegroundLock... I can't see why this would be better or worse than what we had before, but if this fixes the warning for you _and_ no other obvious issues arise, I'm all for it. This approach does look more explicit. But I'm not sure whether the old code was written like it was for a specific purpose...

So imo, let's go for it and we'll see what happens.

- Milian Wolff


On Sept. 2, 2014, 8:23 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120035/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 8:23 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Fix 'destroyed locked mutex' warning
> 
> The problem was that 'internalMutex' in foregroundlock.cpp was still
> being locked.
> 
> Not sure if this can cause any harm, thus putting it on review board
> first. Please comment.
> 
> 
> Diffs
> -----
> 
>   util/foregroundlock.cpp 210a6274404278f1c97f10845c0ce257e250b306 
> 
> Diff: https://git.reviewboard.kde.org/r/120035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140902/1950e582/attachment.html>