Review Request 120032: kdevelop unit tests: port to consistent naming scheme
Kevin Funk
kfunk at kde.org
Tue Sep 2 07:23:41 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120032/#review65672
-----------------------------------------------------------
Ship it!
Thanks for the patch. Looks good to me!
- Kevin Funk
On Sept. 1, 2014, 8:18 p.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120032/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 8:18 p.m.)
>
>
> Review request for KDevelop and Kevin Funk.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> rename unit tests as in kdevplatform
> port to ecm_add_test() cmake macro when needed
> adapt headers guardian
>
> as suggested by aleix, patch generated with --find-copies-harder option to simplify review
>
>
> Diffs
> -----
>
> debuggers/gdb/CMakeLists.txt 47bf0c4
> debuggers/gdb/unittests/gdbtest.h
> debuggers/gdb/unittests/gdbtest.cpp d6dd5e6
> formatters/astyle/tests/CMakeLists.txt fd5634f
> formatters/astyle/tests/astyletest.h c6cb08a
> formatters/astyle/tests/astyletest.cpp ef31b27
> kdeintegration/kdeprovider/tests/CMakeLists.txt a39ce3d
> kdeintegration/kdeprovider/tests/kdeprojectsreadertest.h 7092d51
> kdeintegration/kdeprovider/tests/kdeprojectsreadertest.cpp 3e65059
> languages/cpp/cppduchain/tests/CMakeLists.txt d9fd37b
> languages/cpp/cppduchain/tests/codeanalysistest.h a2d3ade
> languages/cpp/cppduchain/tests/codeanalysistest.cpp f0fbe88
> languages/cpp/cppduchain/tests/test_duchain.h 5fc9e67
> languages/cpp/cppduchain/tests/test_expressionparser.h 8e011ef
> languages/cpp/cppduchain/tests/test_expressionparser.cpp 4edb253
> languages/cpp/cppduchain/tests/test_sourcemanipulation.h b577835
> languages/cpp/cppduchain/tests/testenvironment.h ce110ea
> languages/cpp/cppduchain/tests/testenvironment.cpp e07fc31
> languages/cpp/cppduchain/tests/testhelper.h 63e4d0d
> languages/cpp/cppduchain/tests/testhelper.cpp 2d69673
> languages/cpp/parser/tests/CMakeLists.txt 44cff62
> languages/cpp/tests/CMakeLists.txt 0291c86
> languages/cpp/tests/test_cppassistants.h e6234c8
> languages/cpp/tests/test_cppcodecompletion.h 9a562ff
> languages/plugins/custom-definesandincludes/tests/CMakeLists.txt 884d10a
> languages/plugins/custom-definesandincludes/tests/definesandincludestest.h ab373cb
> languages/plugins/custom-definesandincludes/tests/definesandincludestest.cpp 0501c17
> projectmanagers/cmake/tests/CMakeLists.txt 2b5c29b
> projectmanagers/custom-buildsystem/tests/custombuildsystemplugintest.h b1d10b1
> projectmanagers/custommake/makefileresolver/tests/test_custommake.h 16c05f1
> projectmanagers/custom-buildsystem/tests/CMakeLists.txt cdd3e4f
> projectmanagers/custom-buildsystem/tests/custombuildsystemplugintest.cpp ec240c3
> projectmanagers/cmake/tests/cmakemanagertest.h c68c79e
> projectmanagers/cmake/tests/cmakemanagertest.cpp 0e01cc1
>
> Diff: https://git.reviewboard.kde.org/r/120032/diff/
>
>
> Testing
> -------
>
> yes, make && ctest
>
>
> Thanks,
>
> Laurent Navet
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140902/a498c915/attachment.html>
More information about the KDevelop-devel
mailing list