Review Request 120905: Fix C++/Qt parsing issues

Milian Wolff mail at milianw.de
Thu Oct 30 15:07:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120905/#review69532
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Oct. 30, 2014, 2:47 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120905/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> I've been getting errors when processing Q_PRIVATE_SLOT macros, which is a big problem in Qt5 because QObject has it.
> 
> This patch seems to fix the problems I've been having.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/setuphelpers.cpp d5b17bc 
> 
> Diff: https://git.reviewboard.kde.org/r/120905/diff/
> 
> 
> Testing
> -------
> 
> Seems to fix my issue, same unit tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141030/d233174e/attachment.html>


More information about the KDevelop-devel mailing list