Review Request 120510: [OS X] make debugger build functional

[Milian Wolff]

> On Oct. 17, 2014, 8:50 a.m., Milian Wolff wrote:
> > looking at the three follow-up hotfixes by Pino, I wonder whether you ever even test-compiled this Rene? Is this even working then?
> 
> René J.V. Bertin wrote:
>     Your concern is justified, but rest assured that the only thing I didn't test were my last changes to your comments. Won't happen again.
>     I just double-checked: "this" is working, probably as well as can be expected (pausing, restarting, setting breakpoints etc all seem to function).
> 
> Milian Wolff wrote:
>     OK. Please take the time in the future to always check before submitting anything whether the stuff works as intended (the minimum to do after fixing review issues is a test-compile).
>     
>     bye
> 
> René J.V. Bertin wrote:
>     Yes. I knew that, I don't know why I failed to do it this time.
>     
>     What's the reason for the order change in gdb.h - a concern with ABI compatibility? I didn't see anything to make me suspect the header (or class) was used outside the gdb plugin, and with the added member being private it seemed safe to put it elsewhere but at the end.

Stuff happens, don't worry. Just want to minimize the chance that this happens again :)

Regarding the change in gdb.h: Without it, you'll get a compiler warning about initialization order. See e.g.: http://stackoverflow.com/questions/1564937/gcc-warning-will-be-initialized-after Nothing related to ABI compatibility.

bye


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120510/#review68598
-----------------------------------------------------------


On Oct. 16, 2014, 4:11 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120510/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:11 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The conditions are united under OS X / Macports to build kdevelop's debugger component: the changes to the CMake files take this into account.
> 
> I have made the required changes in stty.cpp to obtain a pty with r/w permissions - on OS X this is done in a way that shares most code with the SGI code. In order not to duplicate more code than necessary I changed the logic of `ptyfd`'s initial value slightly, allowing to distinguish between uninitialised and error return values.
> 
> One has to install an uptodate gdb version (e.g. through MacPorts) and follow the instructions to give it the required permissions to function. Once that's done, the debugger component starts correctly, and appears to communicate with the gdb ("ggdb") slave process.
> 
> The gdb version in MacPorts does not react to SIGKILL, which is the signal used by KDevelop to interrupt a programme being debugged. I solved that issue by retrieving the debugged application's pid from the gdb output, and sending the signal to that application instead of to gdb.
> 
> 
> Diffs
> -----
> 
>   debuggers/CMakeLists.txt 8fe222c 
>   debuggers/gdb/CMakeLists.txt 3d1125c 
>   debuggers/gdb/gdb.h 6f99a60 
>   debuggers/gdb/gdb.cpp 68e1768 
>   debuggers/gdb/stty.cpp 736fff4 
> 
> Diff: https://git.reviewboard.kde.org/r/120510/diff/
> 
> 
> Testing
> -------
> 
> OS X 10.6.8 with kdelibs 4.14.1 and kdesdk git/{1,4}.7 . Gdb 7.7.1 from MacPorts, compiled with python 2.7 support.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141017/835e0ad3/attachment.html>