Review Request 120240: Add utility to modify include paths

[Sergey Kalinichev]

> On Oct. 14, 2014, 5:48 p.m., Maciej Cencora wrote:
> > languages/plugins/custom-definesandincludes/includepathsconverter.cpp, line 140
> > <https://git.reviewboard.kde.org/r/120240/diff/2/?file=313389#file313389line140>
> >
> >     Testing shows this should be without the '-0' args for xargs command. Otherwise all paths from .kdev_include_paths end up as one big line.

Agree, and I've already fixed it: ddf3f820


> On Oct. 14, 2014, 5:48 p.m., Maciej Cencora wrote:
> > languages/plugins/custom-definesandincludes/includepathsconverter.cpp, line 141
> > <https://git.reviewboard.kde.org/r/120240/diff/2/?file=313389#file313389line141>
> >
> >     Actually I cannot find a good usecase for add/removing single path. For me setting all paths at once for given subdir is enough.

Not sure what you mean by that and why is it a problem at all... 
E.g. you still can add all include path with xargs (even if there is only one of them). Also you can manually add/remove all/one include paths even without using it.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120240/#review68393
-----------------------------------------------------------


On Oct. 3, 2014, 10:13 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120240/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 10:13 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 338968
>     http://bugs.kde.org/show_bug.cgi?id=338968
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This utility makes it possible to modify project include paths from command line.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/CMakeLists.txt a36fd20 
>   languages/plugins/custom-definesandincludes/includepathsconverter.h PRE-CREATION 
>   languages/plugins/custom-definesandincludes/includepathsconverter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141017/ca4756a1/attachment-0001.html>