Review Request 120317: WIP: Config pages without KCMs

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120317/
-----------------------------------------------------------

(Updated Okt. 15, 2014, 5:45 nachm.)


Review request for KDevelop.


Changes
-------

fix issue + rebase on latest master


Repository: kdevplatform


Description
-------

Everything seems to work fine with the converted config pages.

This is a huge diff, should I maybe push my changes to a new branch or to some other repository?


Diffs (updated)
-----

  CMakeLists.txt 6a8987db82b5dd589b01718120c7c8021b91f1c4 
  interfaces/CMakeLists.txt 4f7fc1c7d9bd93865e4db5aac71349fbfa3b0d09 
  interfaces/configpage.h PRE-CREATION 
  interfaces/configpage.cpp PRE-CREATION 
  interfaces/iplugin.h b101ae46fa430101c21a1c8eb8699674cbb1977b 
  interfaces/iplugin.cpp a17cd173c1836fc298a3f66f3066f0e4520c8510 
  plugins/projectfilter/CMakeLists.txt 7fc4226bc253e033633916d058f0fc32a1f4cb6f 
  plugins/projectfilter/kcm_kdevprojectfilter.desktop.cmake 2d728b3fcb6b0cd8b6976771a214f270995bc2b7 
  plugins/projectfilter/projectfilterkcm.h 01d143469528117589c86853e5847fad6bc2aaaf 
  plugins/projectfilter/projectfilterkcm.cpp 7eaba23ca09bfedb76fde50a4ff02b28b009c31a 
  plugins/projectfilter/projectfilterprovider.h cb1fa978e0c40fcf8cf5e3fcaf73294c1b9d314e 
  plugins/projectfilter/projectfilterprovider.cpp e22198349f02675572b1396e7a02bac1b43d2eb8 
  project/CMakeLists.txt 948e7ffd8a1e4c8fd4982ed1ad208c7b616bc637 
  project/projectconfigpage.h PRE-CREATION 
  project/projectkcmodule.h fe40e9c3ad05963a5c7986110d1d4cb3e3fa5438 
  shell/CMakeLists.txt d30897867af75bda6054852925ae39f8b08c80b7 
  shell/configdialog.h PRE-CREATION 
  shell/configdialog.cpp PRE-CREATION 
  shell/editorconfigpage.h PRE-CREATION 
  shell/editorconfigpage.cpp PRE-CREATION 
  shell/plugincontroller.cpp d8679afa637bf5f91a4fc9565639766e49ebac83 
  shell/projectcontroller.h 08cb7cbfec32cac918d674ed9a076ce9286ffd30 
  shell/projectcontroller.cpp e549155a3b7fc3ac3e6c642c2c9e2c123af11b7c 
  shell/settings/CMakeLists.txt adde8f22976732e5e5280cea3289caddd40f8b94 
  shell/settings/kcm_kdev_pluginsettings.desktop.cmake 10d126ed24adc10d3e6f7183d7b97677c661287e 
  shell/settings/kcm_kdev_uisettings.desktop.cmake 336e233c2cb1570a2d8523680938f1d094a9a915 
  shell/settings/pluginpreferences.h 12f9d233d9a06739ff0e460e5c41ff92f9431af3 
  shell/settings/pluginpreferences.cpp 0c930961ed55b64fccd56f611cfd48b5a99eb55e 
  shell/settings/uipreferences.h 34c46f3902cf06156c7f8279e6672ebb7a06a31e 
  shell/settings/uipreferences.cpp c8ba26201516241e29f76db4c6e448de787c4704 
  shell/uicontroller.h 797fa198ed17608e88f2a9e9a03f8072c5ebf45d 
  shell/uicontroller.cpp 64b75099026a31d4e85f30ec7127bc24c9ba1882 

Diff: https://git.reviewboard.kde.org/r/120317/diff/


Testing
-------

Dialog is shown correctly, apply, okay work correctly.

Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)


File Attachments
----------------

kdev_config_new.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png
kdev_config_new1.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/f4f16e26-e6dd-4c98-9969-588342f85f4c__kdev_config_new1.png
plugin enabled -> entry exists
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7130af0f-5e23-45cf-b781-ebe318be8369__kdev_config_new2.png
plugin unloaded -> entry disappears
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dff38c1f-2b3d-4ab7-a97d-adff0a99bb3d__kdev_config_new3.png


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141015/42804bcc/attachment-0001.html>