Review Request 120575: Use qCDebug instead of KDebug

Tue Oct 14 10:31:37 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120575/#review68372
-----------------------------------------------------------

Ship it!

Just skimmed the huge patch - many thanks (again!) for taking up such a boring task and seeing it through. That is much appreciated!

- Milian Wolff

On Oct. 14, 2014, 12:06 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120575/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 12:06 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Use qCDebug instead of KDebug
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custommake/custommakemanager.cpp ff6d750dc738ca64456acf9537ccf86e8c3293f2 
>   projectmanagers/custommake/makefileresolver/tests/test_custommake.cpp 041f6f5f686f69e6c4974ab38e465cebb296da6b 
>   providers/ghprovider/ghresource.cpp 27ead0553f1998c36468181d33edafb7da3e5039 
>   utils/okteta/oktetawidget.cpp 84fff22a95f5ef25e394eb6014f48888dc48f450 
>   projectmanagers/custom-buildsystem/debugarea.cpp a710f7b98e84a195d51008f2a92eedb4abe53a12 
>   projectmanagers/custom-buildsystem/tests/kcmuitestmain.cpp 27b5ee810c3315fcf9763426c7b167ef8d56de7b 
>   projectmanagers/custom-buildsystem/tests/test_custombuildsystemplugin.cpp d64ba8c83557e5c0975bf7f536a26f2dc9acf8e2 
>   projectmanagers/custommake/CMakeLists.txt acb103581ac18366522493221ff0c96ada391988 
>   projectmanagers/cmake/parser/cmakeparserutils.cpp 6aa1111036ac301c041ef774d9691b5653cb2bc4 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 59824948927a3691afefd2c2d2abfc54d366cc3b 
>   projectmanagers/cmake/parser/generationexpressionsolver.cpp 32f9d83ba7d1c957e4a137b522722083202ffe03 
>   projectmanagers/cmake/testing/qttestdelegate.cpp 3f70ff24c4198c83bca806f13779b4e74db196f9 
>   projectmanagers/cmake/tests/cmakecompliance.cpp 48153538724d35714dcbdc6f02d07a1f859157e6 
>   projectmanagers/custom-buildsystem/configwidget.cpp 7157e1574b89e491277d45ee57999bf50e454ca7 
>   projectmanagers/custom-buildsystem/debug.h PRE-CREATION 
>   projectmanagers/cmake/testing/ctestrunjob.cpp 35630235933e843e23b33d2b3df558304328e9ed 
>   projectmanagers/cmake/testing/ctestsuite.cpp 886ca4c31fde3e1cb480356049b11ed6641f95c3 
>   projectmanagers/cmake/testing/ctestutils.cpp c6ad1bd3a0d977b03f24a192959c286fa2055b1f 
>   projectmanagers/cmake/parser/variablemap.cpp b63707b7f9375bd0f1ce484a506bb418be09da9f 
>   projectmanagers/cmake/settings/cmakecachedelegate.cpp dfae87b987aff4f1df0a107955e2193f5009c854 
>   projectmanagers/cmake/settings/cmakecachemodel.cpp 2c63c293a2b8fea489834dd58e5a7ab5f1bfa7e5 
>   projectmanagers/cmake/settings/cmakepreferences.cpp d085da8f5bb978d37f27c55d45ad5440682ca06b 
>   projectmanagers/cmake/testing/ctestfindjob.cpp a9836ab8b8bb508d7f973eda6b007c42e65f944f 
>   projectbuilders/makebuilder/makejob.cpp d898858dbceadc92a6f5a480c64ca409aa54bb6d 
>   projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp 45a954af53b747861acfbedfa729ad77b6cb0a6a 
>   projectbuilders/ninjabuilder/ninjajob.cpp 13d27e301e9564754b60d00e9d189a09a95aae4c 
>   projectmanagers/cmake/CMakeLists.txt 260c0853c7e0f03349dde19566c49555c3a20c5b 
>   projectmanagers/cmake/cmakebuilddirchooser.cpp dcfd30bf8de2f249a9256de72d301eb447816549 
>   projectmanagers/cmake/cmakecommitchangesjob.cpp 94304062fdc7177f9f2641914b0b59000862cb46 
>   projectmanagers/cmake/cmakedocumentation.cpp 7183f28d8fa15355b828994ed87c913679536094 
>   projectmanagers/cmake/cmakehelpdocumentation.cpp 582352a4dbe9b25adc01648bf97fad714cbdca16 
>   projectmanagers/cmake/cmakeimportjob.cpp 5281cdb8259c13246f759ae04fe5c8060aae7ad6 
>   projectmanagers/cmake/cmakeimportjsonjob.cpp bd2fec4ff73c2b9b86a61696b8af23408236b76b 
>   projectmanagers/cmake/cmakemanager.cpp 53f571096374075dbb52d427d24008041cd3d0d6 
>   projectbuilders/makebuilder/makebuilderpreferences.cpp f5ee9ec6ad85917dce942aceb5c30b9e7196e57c 
>   projectbuilders/cmakebuilder/debug.h PRE-CREATION 
>   projectbuilders/cmakebuilder/prunejob.cpp c364671ee23bb14c8a22cfad82bb623e235ac520 
>   projectbuilders/makebuilder/CMakeLists.txt 85681a8e94be11447795ed91e41fe7d7428ce950 
>   projectbuilders/makebuilder/debug.h PRE-CREATION 
>   projectbuilders/makebuilder/makebuilder.cpp 15c89df33b6131042d93de70bd41fe94a9728d4e 
>   projectbuilders/cmakebuilder/cmakebuilder.cpp 7fd7d169f96934ef412dbfe4f71a6b7a0b89c06d 
>   projectbuilders/cmakebuilder/cmakejob.cpp bd9ff42040176ab4ecf0be7b4907023555e2d4f4 
>   languages/cpp/includepathcomputer.cpp ececfe6a835edb4949b827757674ea6f85807dcb 
>   languages/cpp/parser/CMakeLists.txt 998a2d4aff8f81b3072a9e215d8ad27ac95ff2dd 
>   languages/cpp/parser/commentparser.cpp 8546e4e2bee7d12b88f4d41b1e1e98e39085848a 
>   languages/cpp/parser/debug.h PRE-CREATION 
>   languages/cpp/parser/dumptree.cpp 5d0df8e2f74406b3c5e6b43c81323bb2606addd8 
>   languages/cpp/parser/headergen/main.cpp f97a2afbc82778e049751bc5749c98751ef843b2 
>   languages/cpp/parser/lexer.cpp 2f28fe7adba29f911abe21eb598fd3ce5155d322 
>   languages/cpp/parser/listnode.h b59fa5f1de135d405ee75d662e226825da7dcf92 
>   languages/cpp/parser/parser.cpp 5ea9ff974fc97d115a8c3dcb9dad1b7d5e350216 
>   languages/cpp/parser/parsesession.cpp a5c3fd854f0440a22bbfd444fe459347bfd2c792 
>   languages/cpp/parser/rpp/chartools.cpp aeffaf99fdd96e9fa28258f5c0f2fb20019794b7 
>   languages/cpp/parser/rpp/debug.h PRE-CREATION 
>   languages/cpp/parser/rpp/pp-engine.cpp 99a7aad78d146131e6c005eef997154a7901f0b5 
>   languages/cpp/parser/rpp/pp-environment.cpp a8c07e7119ab493a79f6fb9171228d327ff04ea0 
>   languages/cpp/parser/rpp/pp-location.cpp c46850c13426e7d6323424077fbb4280ae0ff97a 
>   languages/cpp/parser/rpp/pp-macro-expander.cpp 36070f0b4418516e8e6cb7e5590f093560970cff 
>   languages/cpp/parser/rpp/pp-stream.cpp 97f4c42550b4016bf7ab9c5c5fba44c459a13e34 
>   languages/cpp/parser/rpp/preprocessor.cpp d263c65fe849b6f51616c96f087016dcb0df343a 
>   languages/cpp/parser/rpp/tests/main.cpp 969344fe880e326e2161e9a06a661ecdad7595d9 
>   languages/cpp/parser/tests/test_generator.cpp 5df00abe48333c6ea356c73ed8a598d6c1ae76bc 
>   languages/cpp/preprocessjob.cpp 4e2f0f71fb4722f582301444f5d38c0ab91827d2 
>   languages/cpp/quickopen.cpp d474cd1f840241e3d157ec0fabba9cb73bf58888 
>   languages/cpp/setuphelpers.cpp cbd78b97037e3d47909588acda6d12bf9fb5cb55 
>   languages/cpp/tests/test_buddies.cpp 5efed99e587983a4c06c8cee4ed9a80cbd8ae6ab 
>   languages/cpp/tests/test_cppcodecompletion.cpp 82ab57d7096a724d119e0a23bc58dcbb76feee3b 
>   languages/cpp/tests/test_cppcodegen.cpp a89715403c1c25737935740f951acdc92d8af39f 
>   languages/plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectincludepathsmanager.cpp 86d971b71c2636399326ab5bf70724ff29fe09ed 
>   languages/plugins/custom-definesandincludes/tests/projectsgenerator.cpp 5d8c385f98f15d58dabe269ff83080b552276121 
>   languages/plugins/custom-definesandincludes/tests/test_definesandincludes.cpp 23fd82024176e8ddcfb86b6575e9560e2fcdaa8c 
>   projectbuilders/cmakebuilder/CMakeLists.txt 20b880d4b4e145cf6332a66a6097428520bd5cbf 
>   languages/cpp/cppduchain/type_visitor.cpp 709711f4382c9dfc6d1dc75506dc7b9519cb4b23 
>   languages/cpp/cppduchain/typebuilder.cpp 4bf8d7b80db54f5787125db31ae6dab056ba2044 
>   languages/cpp/cppduchain/typeconversion.cpp 0fa820fe98358e7827f7dc8a7cb75803efe431f3 
>   languages/cpp/cppduchain/typeutils.cpp 48bb796389ed51beefd1db4c8b4b0c42e9a9e77c 
>   languages/cpp/cppduchain/usebuilder.cpp c852b304d0369870c9451e1158c17149d9a8b67a 
>   languages/cpp/cppduchain/usedecoratorvisitor.cpp 79a559a4d0e959d47749cbfd1ca0a47a63d831f4 
>   languages/cpp/cppduchain/viablefunctions.cpp b1f08bdcfc585c6b36ee6891e37f2d1480e290c4 
>   languages/cpp/cpplanguagesupport.cpp 087c72573d1d6bf411a4fdd856752e9d40d23fe5 
>   languages/cpp/cppparsejob.cpp e0adbdcb3aaf3c3023056a3667a7e80bf5b33b52 
>   languages/cpp/cpputils.cpp 87471ec601792fa889d7b2ed9b4b989e6d63ee30 
>   languages/cpp/debug.h PRE-CREATION 
>   languages/cpp/cppduchain/sourcemanipulation.cpp fcf3bbe906e4495615016b7f9c3e207c630a4c2d 
>   languages/cpp/cppduchain/templatedeclaration.cpp af0971bd9b75b24a8a41d6e56e57ec4f27633d1d 
>   languages/cpp/cppduchain/templateresolver.cpp d73f021ed3f5b0473d081f2efc4c2652e6bf96b8 
>   languages/cpp/cppduchain/tests/test_duchain.cpp 5e3a8750c49fb88df2bd6ea4ad45a703455069f2 
>   languages/cpp/cppduchain/tests/test_expressionparser.cpp 3a315edf7e3b37fde311e56c54f5f24a0562eb8e 
>   languages/cpp/cppduchain/tests/test_helper.cpp b264f915224dc9457bff3d96fbba501cbaf86b62 
>   languages/cpp/cppduchain/overloadresolution.cpp 1892733251cc6dd85831663edfcd5670d98fb504 
>   languages/cpp/cppduchain/overloadresolutionhelper.cpp 69301b5327c789f703ab7a8cb51ce1189eb03b6d 
>   languages/cpp/cppduchain/expressionvisitor.cpp f937e1a3f68f07a0020148c2b45c6a5f96a845aa 
>   languages/cpp/cppduchain/missingdeclarationassistant.cpp eb32b14138ca1b19aaaf6610be399c958e708679 
>   languages/cpp/cppduchain/name_visitor.cpp 15ae8771d51935611b25fecf773e67a8470b0591 
>   languages/cpp/cppduchain/declarationbuilder.cpp d642e63e2fc1cd20e1b14fb573c6b0bed869d392 
>   languages/cpp/cppduchain/dumpchain.cpp 26280b0a24dbd64427cef0fdf901dd6b19d164b8 
>   languages/cpp/cppduchain/dumptypes.cpp 248540902bf5369d5df53d9b2ea5429eff5e56cd 
>   languages/cpp/cppduchain/environmentmanager.cpp b0e33c44ef93f30409984ccd2d176a50b8d8fdc2 
>   languages/cpp/cppduchain/expressionparser.cpp be2832887a4907fa8f57aecfeea4a73a27c021d5 
>   languages/cpp/cppduchain/cppeditorintegrator.cpp 745b8faaaa5ce033173f34129d2accf458137db0 
>   languages/cpp/cppduchain/cpppreprocessenvironment.cpp fe6eef4025726757e66c884d818664c4a32c04cd 
>   languages/cpp/cppduchain/debug.h PRE-CREATION 
>   languages/cpp/cppduchain/CMakeLists.txt 14c170bbe601efeef9fd00b20bfd77f0cf212638 
>   languages/cpp/cppduchain/adlhelper.cpp dab81c3de7892f2553c7675e502fcca5a05fc15c 
>   languages/cpp/cppduchain/builtinoperators.cpp 24762e0f18aaae263ee47cf1408a1d91e134b08c 
>   languages/cpp/cppduchain/contextbuilder.cpp 6f6077a355ab93c6a6106b6279b6faa63325e86c 
>   languages/cpp/cppduchain/controlflowgraphbuilder.cpp 32769c8300fc9561089f92e94ae8fc5a8a269127 
>   languages/cpp/cppduchain/cppduchain.cpp 1a1d840448802444103de606f816efbc187607ef 
>   languages/cpp/cppduchain/cppducontext.h 6d1f41ea663993ec8592fab6045d2173c7d51524 
>   languages/cpp/cppduchain/cppducontext.cpp 6153471563d8d26fd54a4a429c106a54a7b6cdf9 
>   languages/cpp/codegen/cppclasshelper.cpp 7102d74d9c50c080f5cc8d72841d9ca713a52134 
>   languages/cpp/codegen/makeimplementationprivate.cpp f2fd8a7fb9989ed26f947b8ab368b879149e34b0 
>   languages/cpp/codegen/simplerefactoring.cpp 4e2f015396167456829753e056d2edd4a96eef08 
>   languages/cpp/codegen/adaptsignatureaction.cpp 0ee698cc86a488b319ca2089a60277fbad0b6f3d 
>   languages/cpp/codecompletion/worker.cpp 7d3418dbe101a2888fc7030a35382bb01ab5a04c 
>   languages/cpp/codecompletion/model.cpp 93a7cb8e6a7fba189b66abbe9e20cfb2a7f36cbc 
>   languages/cpp/codecompletion/missingincludeitem.cpp 8d613c10c14eb776bd86d56e46f00fa192e851ae 
>   languages/cpp/codecompletion/item.cpp 47a276299ba2a41906bfb53f5a2e4d42cdc17e96 
>   languages/cpp/codecompletion/implementationhelperitem.cpp d6365270a619e173969e09bb9d752471f18b908d 
>   languages/cpp/codecompletion/context.cpp 9b693356f3b22cbf0c1743ec0dd591c2b3da9f66 
>   languages/cpp/CMakeLists.txt 02f338fd786ff48f6db64ddf6870f1da3e529173 
>   kdeintegration/kdeprovider/kdeprojectsreader.cpp bec09550471ee3d6a5278e33f74dd046bbe54597 
>   kdeintegration/kdeprovider/kdeprojectsmodel.cpp efff9a8aeef73f180726d9571709cba8ffaed611 
>   kdeintegration/executeplasmoid/plasmoidexecutionjob.cpp d2a276dbad943d8ab3a0af1abf2ccffd5729073c 
>   kdeintegration/executeplasmoid/plasmoidexecutionconfig.cpp cfe67cb198207082822abd012aec2c216d3460f7 
>   kdeintegration/executeplasmoid/executeplasmoidplugin.cpp 373cd3318eae8ffb90bfc0802b7037375b9f554d 
>   kdeintegration/executeplasmoid/debug.h PRE-CREATION 
>   kdeintegration/executeplasmoid/CMakeLists.txt e2813710a560fd2ce160cef7074f6bdacf8fb1c3 
>   formatters/customscript/customscript_plugin.cpp 788a7998303dc9e4100c793b046d53d38a1fbb59 
>   formatters/astyle/tests/CMakeLists.txt 6b9f673c78268eb87352d0e3cf07ea1b59108606 
>   formatters/astyle/debug.cpp PRE-CREATION 
>   formatters/astyle/debug.h PRE-CREATION 
>   formatters/astyle/astyle_formatter.cpp aeb838f96cb377529bdb34470e52fcf440af0f3d 
>   formatters/astyle/astyle_preferences.cpp 1e1df600c516d11ec11d41e8397ca680db5c5f1d 
>   app/main.cpp a4a8be64648f2e11897530f9042ff67983cd4949 
>   app/splash.cpp ac7e9dfe10d89b8e9f06c34a2abf561d8cacfd40 
>   debuggers/gdb/CMakeLists.txt 58590164d521643f2170ee751c45e06337ddf58a 
>   debuggers/gdb/breakpointcontroller.cpp 7cc8c26e1a1ddbd0ae8b5a95e87b0c1c5bd9a9ae 
>   debuggers/gdb/debug.h PRE-CREATION 
>   debuggers/gdb/debuggerplugin.cpp 4a46b13bbd671625916553a2847967adf7bd95fd 
>   debuggers/gdb/debugjob.cpp 455fb17cb8fa3384af8e899298f8a389bbb2c9e6 
>   debuggers/gdb/debugsession.cpp f349170369e129bbf0ff9944626438e4b9a9115e 
>   debuggers/gdb/disassemblewidget.cpp 55561ac4f316ded4d1d54c0e654a771146887137 
>   debuggers/gdb/gdb.cpp fa4a640683cda98e5458f569eebb466b12399665 
>   debuggers/gdb/gdblaunchconfig.cpp 3960ef979d39811387bf46d57e51b9b92674c3b0 
>   debuggers/gdb/gdboutputwidget.cpp debf1234220c12939d80ff5fe1eff721423dce2d 
>   debuggers/gdb/gdbparser.cpp 4d371cbc9591bd0196e212816f439aec4de36f03 
>   debuggers/gdb/memviewdlg.cpp d0e1b4af5b2e8b2d586b23fc7fb8a164c4a9909a 
>   debuggers/gdb/registers/modelsmanager.cpp ea71154733f1af91e241832c33c6730639a491ed 
>   debuggers/gdb/registers/registercontroller.cpp a47cfe4c2c4ff15a7cef791f6df77bfb2ab36879 
>   debuggers/gdb/registers/registercontroller_arm.cpp 785242190009d29cebbae19fc4be63301a002e9d 
>   debuggers/gdb/registers/registercontroller_x86.cpp 8b2c8323113ad3f87731f5f6092ccfaa998c5c90 
>   debuggers/gdb/registers/registersmanager.cpp b48509f98de671552d17dd5146fec7f71d6f56bb 
>   debuggers/gdb/registers/registersview.cpp 78c09b5478610bd4225465e8b620c631dfd16ab5 
>   debuggers/gdb/stty.cpp d40b04f5fbfc76d84eb99da2f8d3856f86a4f2ca 
>   debuggers/gdb/unittests/test_gdb.cpp 3442639e7d62e6b31b3846056574b1694ae21190 
>   debuggers/gdb/variablecontroller.cpp 5086b59a6a9dda4351ebd3a3a569f0a94e6e663f 
>   documentation/qthelp/CMakeLists.txt b075e28c5cf05eaa509f1760baa21f19a0303bb9 
>   documentation/qthelp/debug.h PRE-CREATION 
>   documentation/qthelp/debug.cpp PRE-CREATION 
>   documentation/qthelp/qthelpconfig.cpp 56c4f5012a862d4756328b513385039a333f68bb 
>   documentation/qthelp/qthelpdocumentation.cpp b16a03f547f2b62635b2e264faff5e485cac6024 
>   documentation/qthelp/qthelpplugin.cpp a79b0d6ab748356ebdf821ba7a0e8d61862b8448 
>   documentation/qthelp/qthelpproviderabstract.cpp 80b10ca05569d00f7c3232247af7f2e46c7e4ce2 
>   documentation/qthelp/qthelpqtdoc.cpp c6de35aaffc3a125355b40d87cd335dc2f193b81 
>   documentation/qthelp/tests/CMakeLists.txt 32de343ea7f92eee666a84f01541b2ea35d8bf99 
>   documentation/qthelp/tests/test_qthelpplugin.cpp 5fce3c38ccae72523a95ea87269d25d2a414171d 
>   formatters/CMakeLists.txt 8217ec0ae661935cfb1a1ef58cdb6797580d9206 
>   formatters/astyle/CMakeLists.txt 603e577e882fd549ad4f0da473bff21508b06594 
>   projectmanagers/cmake/parser/cmakelistsparser.cpp 2e26098b99674c6f87b2e8d9c75d781615ab897c 
>   projectmanagers/cmake/parser/cmakedebugvisitor.cpp 813160b46367e48faea4116ab5ca18a8e4f7d614 
>   projectmanagers/cmake/cmakemodelitems.cpp 2a603a61ebb1580ac830aa08f4936a1ed40e0edf 
>   projectmanagers/cmake/cmakeutils.cpp 693072767f255b194a46182dd67c7532cfef1af9 
>   projectmanagers/cmake/debug.h PRE-CREATION 
>   projectmanagers/cmake/debug.cpp PRE-CREATION 
>   projectmanagers/cmake/duchain/cmakeparsejob.cpp 18c42fd5963d8e6e6a5b0f76a494277fb26b51c9 
>   languages/cpp/codegen/adaptsignatureassistant.cpp 30f47782406aada87d913de118f1d01d248ad8a0 
>   projectmanagers/cmake/parser/cmakecondition.cpp e8aff4f5d08ea596815faa3c0cc0eeb79c8c528b 
>   projectmanagers/cmake/parser/cmakecachereader.cpp 2463b07bd65b89f5346cd3c5fee268ca49c93490 
>   projectmanagers/cmake/parser/cmakeast.cpp ef507f731a0984f5bd369f180d5b7915553a2df7 
> 
> Diff: https://git.reviewboard.kde.org/r/120575/diff/
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141014/7d60f3ed/attachment-0001.html>