Review Request 120571: Port KAppTemplate away from KDELibs4Support

[Milian Wolff]

> On Oct. 13, 2014, 2:07 p.m., Milian Wolff wrote:
> > kapptemplate.cpp, line 78
> > <https://git.reviewboard.kde.org/r/120571/diff/1/?file=318214#file318214line78>
> >
> >     that looks wrong, is that really required? don't use c-style casts then
> 
> Simon Wächter wrote:
>     As I said in IRC: registerField() uses an UI element and a property (In this case the QLineEdit and the text() method of the QLineEdit). To register an element, the element needs a QWidget as base class - KUrlRequester and KLineEdit don't have one - the downcast from KLineEdit to QLineEdit makes it possible to use the text as property. Do you have a smoother solution for that ? For more information see: http://qt-project.org/doc/qt-5/qwizardpage.html#registerField

Huh? http://api.kde.org/frameworks-api/frameworks5-apidocs/kcompletion/html/classKLineEdit.html <-- shows that QWidget is a base class of KLineEdit so this should work. What compile error do you get when you don't do the cast? What happens if you use static_cast<QLineEdit*>(ui_properties.kcfg_url->lineEdit()) instead?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120571/#review68308
-----------------------------------------------------------


On Oct. 13, 2014, 3:40 p.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120571/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 3:40 p.m.)
> 
> 
> Review request for KDevelop and Jonathan Riddell.
> 
> 
> Repository: kapptemplate
> 
> 
> Description
> -------
> 
> This patch drops the KDE4 library dependency:
> 
> - Removed the KDE4 library and 3 other CMake modules that where triggered by the support library
> - Fixed the includes and removed the old ones
> - Switched from kDebug to qCDebug
> - Rewritten copy and macro expanding
> - Removed a (unused) signal that tries to override the same signal in the base class (Results in warning)
> - Removed whitespaces
> 
> Please check:
> - Take a look at generatepage.cpp --> unpackArchive and generatepage.cpp --> finishFile. Is it a good idea to extract all macros in a file - even when it is a "binary blob" like an ODF or binary etc. ? Does someone know a good way to solve this ? In the end I always get stuck in a static file ending or mime type check (But there are some many minetypes ...)
> 
> Future:
> - Move the functionality inside a library, so that KAppTemplate and later KDevelop can use it to find file and project templates
> - Readd input checking patterns to the forms (Version, email etc)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4ea08d4 
>   apptemplatesmodel.cpp 2ef00d7 
>   choicepage.cpp 7ae478f 
>   generatepage.h 22085d1 
>   generatepage.cpp 66b98ab 
>   kapptemplate.h 77f43c0 
>   kapptemplate.cpp b1abcab 
>   logging.h PRE-CREATION 
>   main.cpp 038238e 
>   properties.ui b1fac73 
> 
> Diff: https://git.reviewboard.kde.org/r/120571/diff/
> 
> 
> Testing
> -------
> 
> Testing was done under a project neon 5 system
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141013/85699ecc/attachment.html>