Review Request 120571: Port KAppTemplate away from KDELibs4Support

[Simon Wächter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120571/
-----------------------------------------------------------

(Updated Oct. 13, 2014, 5:40 p.m.)


Review request for KDevelop and Jonathan Riddell.


Changes
-------

Fixed 4 issues. The issue with the cast still needs input.


Repository: kapptemplate


Description
-------

This patch drops the KDE4 library dependency:

- Removed the KDE4 library and 3 other CMake modules that where triggered by the support library
- Fixed the includes and removed the old ones
- Switched from kDebug to qCDebug
- Rewritten copy and macro expanding
- Removed a (unused) signal that tries to override the same signal in the base class (Results in warning)
- Removed whitespaces

Please check:
- Take a look at generatepage.cpp --> unpackArchive and generatepage.cpp --> finishFile. Is it a good idea to extract all macros in a file - even when it is a "binary blob" like an ODF or binary etc. ? Does someone know a good way to solve this ? In the end I always get stuck in a static file ending or mime type check (But there are some many minetypes ...)

Future:
- Move the functionality inside a library, so that KAppTemplate and later KDevelop can use it to find file and project templates
- Readd input checking patterns to the forms (Version, email etc)


Diffs (updated)
-----

  CMakeLists.txt 4ea08d4 
  apptemplatesmodel.cpp 2ef00d7 
  choicepage.cpp 7ae478f 
  generatepage.h 22085d1 
  generatepage.cpp 66b98ab 
  kapptemplate.h 77f43c0 
  kapptemplate.cpp b1abcab 
  logging.h PRE-CREATION 
  main.cpp 038238e 
  properties.ui b1fac73 

Diff: https://git.reviewboard.kde.org/r/120571/diff/


Testing
-------

Testing was done under a project neon 5 system


Thanks,

Simon Wächter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141013/1c79cc33/attachment.html>