Review Request 120452: Fix compilation

Kevin Funk kfunk at kde.org
Fri Oct 3 09:59:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120452/#review67847
-----------------------------------------------------------



testprovider/phpunitrunjob.h
<https://git.reviewboard.kde.org/r/120452/#comment47262>

    Call that `UnprotectedExecuteCompositeJob` or somthing.



testprovider/phpunitrunjob.h
<https://git.reviewboard.kde.org/r/120452/#comment47263>

    Just do:
    ```
    public:
    using ExecuteCompositeJob::subjobs();
    ```


- Kevin Funk


On Oct. 1, 2014, 5:15 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120452/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 5:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> KDevelop::OutputJob::subjobs() is protected so I've wrapped problematic code with class that allows fetching last subjob.
> 
> 
> Diffs
> -----
> 
>   testprovider/phpunitrunjob.h c18002d 
>   testprovider/phpunitrunjob.cpp 9e36461 
> 
> Diff: https://git.reviewboard.kde.org/r/120452/diff/
> 
> 
> Testing
> -------
> 
> Code compiles, isntalls, loads and at works in basic scenarios I have tested it in.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141003/8dbc8a17/attachment.html>


More information about the KDevelop-devel mailing list