Review Request 121285: Use new style connect in KActionCollection::addAction()

[Aleix Pol Gonzalez]

> On Nov. 29, 2014, 8:36 a.m., Kevin Funk wrote:
> > Alright, https://git.reviewboard.kde.org/r/121283/ needs to be merged first.
> > 
> > OTOH, I'm not sure we like the raise to KF 5.5 for such a trivial patch. We might want to slowly settle for a minimum required KF5 version...
> 
> Alexander Richardson wrote:
>     Should be no need to commit this straight away, I doubt rebasing will introduce many conflicts.

Well, we are probably requiring a new KTextEditor anyway. I think it's fine for now to keep expecting people to re-compile kf5 regularly.

I guess most people here use kde-src-build, no?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121285/#review71072
-----------------------------------------------------------


On Nov. 28, 2014, 8:58 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121285/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2014, 8:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Use new style connect in KActionCollection::addAction()
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eaf32e7234ba7530e363ef07e75970ec4d21c0cc 
>   language/codegen/applychangeswidget.cpp c6460db12e6faba1115d7eb23f940d9a837ecea8 
>   plugins/documentswitcher/documentswitcherplugin.cpp e4592377cc355c2a3f5d2f7b60c397094140de85 
>   shell/mainwindow_p.cpp 82429aedaf7ff8d5692037e9c77c9028131b0c32 
>   plugins/appwizard/appwizardplugin.cpp e8e9472caa62370191647bdc6fbc456837f0e96f 
>   plugins/codeutils/codeutilsplugin.cpp 49efa7731988dfa611049b8c75033da10e32462b 
> 
> Diff: https://git.reviewboard.kde.org/r/121285/diff/
> 
> 
> Testing
> -------
> 
> This requires https://git.reviewboard.kde.org/r/121283/
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141129/5b6af016/attachment.html>