Review Request 120317: WIP: Config pages without KCMs

Milian Wolff mail at milianw.de
Sun Nov 23 20:31:19 UTC 2014 


> On Nov. 23, 2014, 3:48 p.m., Milian Wolff wrote:
> > Yay! I only have one small issue regarding qDebug and the move of the environment configure button. Please let the latter stay in util/. That should work fine without any circular dependency, since util only links against interfaces, but not shell. So shell can link against util, if it doesn't do that already, no?
> 
> Alexander Richardson wrote:
>     EnvironmentPreferences is in shell/ and now that we don't use KCMs anymore we have to construct the class manually.
>     Since util can't depend on shell I had to move the envconfigurebutton to shell/

ah yes of course. thanks for the explanation - I dropped the issues. just go ahead to push this in then, but please make sure your qDebug() statements are categorized.

thanks!


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120317/#review70813
-----------------------------------------------------------


On Nov. 23, 2014, 11:38 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120317/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 11:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Everything seems to work fine with the converted config pages.
> 
> This is a huge diff, should I maybe push my changes to a new branch or to some other repository?
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt e4f2347e531fd1005bf8147b6db155e8bbc1972e 
>   shell/configdialog.h PRE-CREATION 
>   project/projectkcmodule.h 8c413bbe18d5f3b623ef72c897a1ba771e7d3a68 
>   plugins/templatemanager/templateconfig.h 2dcab9075c16351fcccdf8725f4c96efd2ab1ca9 
>   plugins/templatemanager/templateconfig.cpp 286bd7ccf20df6075eb915a66f9c5ce40c29b3d2 
>   plugins/templatemanager/templateconfig.ui  
>   plugins/templatemanager/templatepage.h ed8a703e6919146b762d657e35d379c33687c74d 
>   plugins/templatemanager/templatepage.cpp 1361a8d54f3732857e621b05113c0fa27f355b3f 
>   plugins/templatemanager/templatepage.ui  
>   project/CMakeLists.txt 948e7ffd8a1e4c8fd4982ed1ad208c7b616bc637 
>   project/interfaces/iprojectbuilder.h c47573a6867c3f81ced411bd973becc29b0c7b94 
>   project/projectconfigpage.h PRE-CREATION 
>   plugins/execute/CMakeLists.txt 00feea61444d52a67b6634f65c93545b3d426d93 
>   plugins/execute/nativeappconfig.cpp a1070715cc72e0851b45c1da6dab6c6c7bb9c10e 
>   plugins/execute/nativeappconfig.ui c7a3540047acf795ce4bab9212242dff274f83c3 
>   plugins/projectfilter/CMakeLists.txt 77e746b075e81d2c0477b1bb547979d658197959 
>   plugins/projectfilter/kcm_kdevprojectfilter.desktop.cmake 2d728b3fcb6b0cd8b6976771a214f270995bc2b7 
>   plugins/projectfilter/projectfilterkcm.h 01d143469528117589c86853e5847fad6bc2aaaf 
>   plugins/projectfilter/projectfilterkcm.cpp 4457066d6d9c2d67d1c3108183b6bc162bdae87a 
>   plugins/projectfilter/projectfilterprovider.h cb1fa978e0c40fcf8cf5e3fcaf73294c1b9d314e 
>   plugins/projectfilter/projectfilterprovider.cpp 102a482de5377fdc4b21a81dcd5c12510c5c1e8c 
>   plugins/templatemanager/CMakeLists.txt 5f42051e4fb6e153e9ccdaef1eb60187225777c9 
>   plugins/templatemanager/Messages.sh  
>   plugins/templatemanager/kdevtemplatemanager_config.desktop.cmake 018b2789eabe97d8ee9f2286783de92526c8a5ba 
>   CMakeLists.txt 580159cfa6ac23cef48004837e7fe3ceea8fe6e3 
>   interfaces/CMakeLists.txt 37c389e90ac37cb57d02a5ed218f67235bd9d6cd 
>   interfaces/configpage.h PRE-CREATION 
>   interfaces/configpage.cpp PRE-CREATION 
>   interfaces/iplugin.h 54c688af8d8a2d016599599466e53a4b289dfa9b 
>   interfaces/iplugin.cpp 800a63fa2f4a9887cd7493a84444197b494e743c 
>   plugins/CMakeLists.txt 2028ebb45ad884ce52d785f9c0cdf5a81a136d8c 
>   shell/configdialog.cpp PRE-CREATION 
>   shell/editorconfigpage.h PRE-CREATION 
>   shell/editorconfigpage.cpp PRE-CREATION 
>   shell/plugincontroller.cpp a0adcddbe1b074adb6cc48c9073f8cde54653025 
>   shell/projectcontroller.h 08cb7cbfec32cac918d674ed9a076ce9286ffd30 
>   shell/projectcontroller.cpp 14da967059768fe0efb08b4afe7992e62a0586b8 
>   shell/settings/CMakeLists.txt c0988fb989e72db7b745c874f62fb620c11bd0ce 
>   shell/settings/bgconfig.kcfgc 8dfe6e314a14972b725f97d341ce6fa5b2795349 
>   shell/settings/bgpreferences.h e516b6395beda6d964cea72c35e694038b84f71a 
>   shell/settings/bgpreferences.cpp a74acf445e687633bb0b5b410f5876ff45fa45af 
>   shell/settings/ccpreferences.h 186b62a09e2fd10a9937689d919d05911e3d77e0 
>   shell/settings/ccpreferences.cpp 710484dc6ffa7a4cfa14d3c6c9e2dd75cbc8bcf0 
>   shell/settings/environmentpreferences.h e7c84f4ec750ace28489829eced5bfc0b9c66718 
>   shell/settings/environmentpreferences.cpp 3fdf16b2035c501d60faf2f9003025fd3b757203 
>   shell/settings/kcm_kdev_bgsettings.desktop.cmake 374e041f35bf49422a76096fa15ced9e6dcef587 
>   shell/settings/kcm_kdev_ccsettings.desktop.cmake 56f8394d7ff93bf755f3771471f9c8528bda9d98 
>   shell/settings/kcm_kdev_envsettings.desktop.cmake 5fe88f5a9ddc90ae8cc6078e5b67b159ede5a2eb 
>   shell/settings/kcm_kdev_pluginsettings.desktop.cmake 10d126ed24adc10d3e6f7183d7b97677c661287e 
>   shell/settings/kcm_kdev_projectsettings.desktop.cmake b1ac9bc4d59a2b3128745ceae79a3b66eda08245 
>   shell/settings/kcm_kdev_uisettings.desktop.cmake 336e233c2cb1570a2d8523680938f1d094a9a915 
>   shell/settings/kcm_kdevsourceformattersettings.desktop.cmake 6f22083488be2d4ad350ab5293a25c56e0797e43 
>   shell/settings/pluginpreferences.h 12f9d233d9a06739ff0e460e5c41ff92f9431af3 
>   shell/settings/pluginpreferences.cpp b0d77d5f61caab17b6b2d243168c48c9b26fa40c 
>   shell/settings/projectconfig.kcfgc 31355435eff9d2306ce98219095ecf02283cc2e9 
>   shell/settings/projectpreferences.h 18a5357829a4293ba284868ca6be6c33134ef8da 
>   shell/settings/projectpreferences.cpp 31e81de0dd97fb458953b700bdfc6c25a5cd9e2f 
>   shell/settings/sourceformattersettings.h e27933c45309ed763db24be1d0ed19d4a183e861 
>   shell/settings/sourceformattersettings.cpp b7daf38b930faa5bfd0bf265fee6f6c01d899bdd 
>   shell/settings/uipreferences.h 34c46f3902cf06156c7f8279e6672ebb7a06a31e 
>   shell/settings/uipreferences.cpp c8ba26201516241e29f76db4c6e448de787c4704 
>   shell/uicontroller.h 7d7c6622cd39a0570a5cd93ce6fd74f0f887c64b 
>   shell/uicontroller.cpp 11ee89808dc6c7e4bff1c4e66ee8f29d02c0db51 
>   util/CMakeLists.txt 9903178297ca5f6fdb391f92792b27b94797b407 
>   util/environmentconfigurebutton.h 9a6503801cb9cdb9384bb68ac8cc7cd4559c12d9 
>   util/environmentconfigurebutton.cpp 9abbd033c2fc346a20c5583e38dc0f41ee15b7f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120317/diff/
> 
> 
> Testing
> -------
> 
> Dialog is shown correctly, apply, okay work correctly.
> 
> Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)
> 
> 
> File Attachments
> ----------------
> 
> kdev_config_new.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png
> kdev_config_new1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/f4f16e26-e6dd-4c98-9969-588342f85f4c__kdev_config_new1.png
> plugin enabled -> entry exists
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7130af0f-5e23-45cf-b781-ebe318be8369__kdev_config_new2.png
> plugin unloaded -> entry disappears
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dff38c1f-2b3d-4ab7-a97d-adff0a99bb3d__kdev_config_new3.png
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141123/cf4d225d/attachment.html>

More information about the KDevelop-devel mailing list