Review Request 121171: Added project name to debug stop job.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121171/#review70625
-----------------------------------------------------------



debuggers/gdb/debugjob.cpp
<https://git.reviewboard.kde.org/r/121171/#comment49423>

    languages can be funky. There is no guarantee that in $random-language it should be "foo: bar". In RTL languages such as arabic, maybe it should rather be "oof :rab"? In general one thus has to use i18n and give translators some context via i18nc.
    
    Also, what do the names look like now? And couldn't there also be launch configs without an associated project? I.e. I think you should check for the validity of project() before dereferencing it.


- Milian Wolff


On Nov. 18, 2014, 7:46 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121171/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 7:46 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 338773
>     http://bugs.kde.org/show_bug.cgi?id=338773
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Added project name to debug stop job to help easily tell apart stop jobs, especially debug sessions.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugjob.cpp 70797f4 
> 
> Diff: https://git.reviewboard.kde.org/r/121171/diff/
> 
> 
> Testing
> -------
> 
> Compiled with kdesrc-build.
> Executed, debuged a test project.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141118/30eeb7ca/attachment.html>