Review Request 121129: KF5: Port KDialog -> QDialog

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121129/#review70407
-----------------------------------------------------------

Ship it!


I'd love to share some more code, either via kdev-util or by putting a helper function into KGuiAddons maybe?


plugins/filetemplates/templateclassassistant.cpp
<https://git.reviewboard.kde.org/r/121129/#comment49231>

    this block is repeated relatively often, couldn't we add a helper function somewhere, maybe into kdev-util for now?



plugins/quickopen/quickopenplugin.cpp
<https://git.reviewboard.kde.org/r/121129/#comment49232>

    :) remove this now, no?



shell/launchconfigurationdialog.cpp
<https://git.reviewboard.kde.org/r/121129/#comment49233>

    style:
    
        Foo::Foo()
            : Parent()
            , m_bla(...)
        {
            ...
        }



shell/openprojectdialog.cpp
<https://git.reviewboard.kde.org/r/121129/#comment49234>

    remove?



shell/settings/editstyledialog.cpp
<https://git.reviewboard.kde.org/r/121129/#comment49235>

    indentation?


- Milian Wolff


On Nov. 15, 2014, 1:59 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121129/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 1:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Some parts/plugins were left out, because I did not verify everything
> was working after the porting scripts did their job
> - plugins/cvs - (don't even know how to trigger the code path)
> - plugins/subversion (lot's of dialogs involved)
> - plugins/snippet/legacy/ (will be dropped anyway, not worth it)
> - plugins/dashboard (not built, what's the state of that anyway?)
> 
> For the rest of dialogs, ported in this patch, I manually tested each
> of them. So everything should still be working as expected.
> Still putting this up for review to have another pair of eyes on the patch.
> 
> REVIEW: 121128
> 
> 
> Diffs
> -----
> 
>   vcs/widgets/vcscommitdialog.ui f32f8a2a9504deff2cbe2a9c9aab40e4e79baa67 
>   vcs/widgets/vcscommitdialog.cpp 77224786235f845edb84e796def20d119f2cca95 
>   vcs/vcspluginhelper.cpp a4dfec71dd2127a31f9a389120558cbcb92f05b6 
>   vcs/dvcs/ui/branchmanager.cpp 6827f3f0c623ca2234c159ae1a1bbcfb0a3d2de1 
>   vcs/dvcs/ui/branchmanager.h ef842f0506727f28db8a102a7f9a70173ba9a8c8 
>   util/environmentconfigurebutton.cpp 7ff85aae0cb71254fd7b8420b597edb7af195fed 
>   shell/uicontroller.cpp 014fa83982fbe0d7bbf73827bd85b2dec2348c54 
>   shell/settings/sourceformattersettings.cpp 4908eaad29c75206e2443aff617c897fee5b353f 
>   shell/settings/environmentwidget.cpp 34558a12195c8c2cc8f890a8ba783d5cbd2e9a9d 
>   shell/settings/editstyledialog.h 8de5a194c6b24b6e166d66c7194b83ce1516f2b7 
>   shell/sessiondialog.ui 711c7d72ac00fc1aa529004328edc49e8edf7d4c 
>   shell/sessiondialog.h 500e9f64f7c5931994277ed265b37777c9755e34 
>   shell/sessioncontroller.cpp 883cb8a505fcad7c9a1a89132ad49ddb954dfba2 
>   shell/sessionchooserdialog.cpp 2c830890398ebf5411a8ac697a637c75d1c72fec 
>   shell/sessionchooserdialog.h e1e4e4d09be0537e83674efcb895488cf040ef11 
>   shell/savedialog.cpp eb3812de0cbdb65d2d30f4ba513d9150de6d995d 
>   shell/savedialog.h a01a17047abc78b838d5327ead6c5562b65d257b 
>   shell/projectcontroller.cpp 6216f1d01c17eb9827d69415a00fd0258959f419 
>   shell/plugincontroller.cpp 898c2e3aeb9ddca1b5bea65680e8003e242f9c07 
>   shell/openprojectdialog.cpp 07893ca99dd67b4348198362736ca2dd61102064 
>   shell/loadedpluginsdialog.cpp 8ed884eef7a1c71ae5bba0c09efc729e4f1a3c46 
>   shell/loadedpluginsdialog.h 5aff5fcd031c4e2004187fc2f71fd0405f59aa86 
>   shell/launchconfigurationdialog.ui 87c79c037c64cd5913fd8d59dae4b2444e7b72eb 
>   shell/launchconfigurationdialog.cpp c6eefc320a563f4f3fba7a259822c8ee2d58e4c8 
>   shell/launchconfigurationdialog.h b0a7d32929f0c61931966a55ac45c8c5d3042dc7 
>   project/projectitemlineedit.cpp 9e9824a7a16baf91e7cf072d8bb70fa238197452 
>   plugins/snippet/snippetplugin.cpp 724c9cdf4bf61b0f56cda1773a1691d20718448b 
>   plugins/reviewboard/reviewpatchdialog.cpp 2d0c191defff01dbabd027e8fea804b483f855c0 
>   plugins/reviewboard/reviewpatchdialog.h b55ee41094bfe49d04b374fc01e47db96fa6d800 
>   plugins/reviewboard/reviewpatch.ui 8e11f5c09e41fab6471bc0ae3de36404e86133cf 
>   plugins/reviewboard/reviewboardplugin.cpp c19f6868742435853784871a57b5986b070988f3 
>   plugins/quickopen/quickopenplugin.cpp a8eaba0b4ea44e2c95d3e4ef08fef2e6ce5cb9eb 
>   plugins/git/stashmanagerdialog.ui 51d6def44d25a2deeb40a667b39e537d5b333fa0 
>   plugins/git/stashmanagerdialog.cpp 16a09c1b804fc00e00fe4f5e9836a58b65c0c986 
>   plugins/git/stashmanagerdialog.h 5eda0caee8b685fe1d8c7e5990fc7d67673b6a62 
>   plugins/filetemplates/templateclassassistant.cpp 51ffae6c19d568a832fa39c299da3143b54b39b3 
>   plugins/externalscript/externalscriptview.cpp 07a6ee083b93cf348432a9e660e8fda90b37f7d7 
>   plugins/externalscript/editexternalscript.ui b8bff47f89d73c4480567a070faa560d5078f6c1 
>   plugins/externalscript/editexternalscript.cpp 4165b25ed67103dfccfacda57124660249be0e1f 
>   plugins/externalscript/editexternalscript.h ecaa1af5c9f26588d265fda288772f69df9a3232 
>   language/codegen/applychangeswidget.h d947f8dd83260a7771b6aaf3ae589ed942de7a89 
>   language/codegen/applychangeswidget.cpp 722fc7a9949da80cab88b45b7450c9750d7ad953 
>   vcs/widgets/vcseventwidget.cpp c4ccda16163acfa63f189fb111e4dc7a3616a5ee 
>   vcs/widgets/vcscommitdialog.h c3b1dd171c78e46a8fbb6f73bafd9a144d3c4d7c 
>   sublime/idealdockwidget.cpp b1d2b4ea5cf156bbe1fb0e90ad4d3f96490ee2cb 
>   vcs/dvcs/dvcsplugin.cpp 7a9dcde7b74d3acca1c8871684d81d15cda31f6a 
>   shell/settings/editstyledialog.cpp 3d7f2dcbb9aed1f841bf6e9f7724adc8a8ba6b67 
>   shell/sessiondialog.cpp db92c056e465f1b889744ee8d82828187bd63816 
> 
> Diff: https://git.reviewboard.kde.org/r/121129/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141115/e8e950f9/attachment.html>