Review Request 121061: Fix environment-cd when launching a debugsession in a path containing spaces

[Nicolas Werner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121061/#review70342
-----------------------------------------------------------



File Attachment: patch with unit test - 0001-Fix-launching-a-debugsession-in-a-path-containing-sp.patch
<https://git.reviewboard.kde.org//r/121061/#fcomment273>

    The test program doesn't check it's current working directory, so if gdb fails to set it, the test wont catch it!
    
    I don't know, how you could check it in a crossplattform way, maybe using Qt?
    
    '''C++
    QString str = QDir::currentDirPath()
    '''
    
    And then check if equal


- Nicolas Werner


On Nov. 13, 2014, 7:52 nachm., Nicolas Werner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121061/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 7:52 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 339231
>     http://bugs.kde.org/show_bug.cgi?id=339231
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Problem: GDBMI only accepts paths containing spaces if they are in double quotes otherwise cd will fail.
> Solution: Add prepend and append double quotes to the dir string instead of using KShell::quoteArg
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp e37c5b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121061/diff/
> 
> 
> Testing
> -------
> 
> I did a patch for 4.7, that fixed the problem, but I can't build master at the moment, so I don't know, if this compiles. It should fix the bug tough, as it is only a quoting issue.
> 
> Should I also attatch the patch for the 4.7 branch?
> 
> 
> File Attachments
> ----------------
> 
> patch with unit test
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/13/57f573ca-fa7e-4478-9be4-8431bf5597e5__0001-Fix-launching-a-debugsession-in-a-path-containing-sp.patch
> 
> 
> Thanks,
> 
> Nicolas Werner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141113/f53b5d52/attachment.html>