Review Request 121045: Convert plugins to new signal/slot syntax (part1)

[Alexander Richardson]

> On Nov. 8, 2014, 7:33 nachm., Kevin Funk wrote:
> > plugins/appwizard/projectvcspage.cpp, line 75
> > <https://git.reviewboard.kde.org/r/121045/diff/1/?file=326850#file326850line75>
> >
> >     Second parameter can just be `nullptr`.

Sadly it doesn't, the explicit cast is required here


> On Nov. 8, 2014, 7:33 nachm., Kevin Funk wrote:
> > plugins/documentview/kdevdocumentviewplugin.cpp, line 51
> > <https://git.reviewboard.kde.org/r/121045/diff/1/?file=326878#file326878line51>
> >
> >     Style: s/KDevelop:://

There is no using declaration, so it is needed.


> On Nov. 8, 2014, 7:33 nachm., Kevin Funk wrote:
> > plugins/externalscript/externalscriptjob.cpp, line 186
> > <https://git.reviewboard.kde.org/r/121045/diff/1/?file=326885#file326885line186>
> >
> >     Style: s/KDevelop:://

No using declaration, so I can't do that.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121045/#review70094
-----------------------------------------------------------


On Nov. 7, 2014, 6:35 nachm., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121045/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 6:35 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Convert appwizard plugin to new signal/slot syntax
> 
> Convert bazaar plugin to new signal/slot syntax
> 
> Fixes one bad connection: argument was changed from time_t to QDateTime
> 
> Convert classbrowser plugin to new signal/slot syntax
> 
> 
> EditorViewManager should inherit publicly from QObject, not priavtely
> 
> 
> Convert contextbrowser plugin to new signal/slot syntax
> 
> 
> Convert cvs plugin to new signal/slot syntax
> 
> 
> Convert documentswitcher and documentview to new signal/slot syntax
> 
> 
> Convert execute and executescript plugins to new signal/slot syntax
> 
> 
> Convert externalscript plugin to new signal/slot syntax
> 
> 
> Convert filemanager plugin to new signal/slot syntax
> 
> 
> Convert filetemplates plugin to new signal/slot syntax
> 
> 
> Convert git plugin to new signal/slot syntax
> 
> 
> Convert grepview plugin to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizarddialog.cpp 52bbdc4ae1fde23fdd2577686c780e47e39344cd 
>   plugins/appwizard/appwizardplugin.cpp d6779eb5a9eede2c705cf14a6cdafca64a9ab901 
>   plugins/appwizard/projectselectionpage.cpp 20cce746a1d4011369dd61f748d4ebf0e0a3f2e2 
>   plugins/appwizard/projectvcspage.cpp 21b57f96526bc63325f7fc6dcde560569bfaeb29 
>   plugins/bazaar/bazaarplugin.cpp 24cf6c2145fcef7e696cf5ab995063faee40cae1 
>   plugins/bazaar/bzrannotatejob.cpp 7c434d959a8652cd4bacd4ac590a6e85f11df336 
>   plugins/bazaar/copyjob.h 3e5c8b8f0e5bc3874e0c8d008c438ca46fa2e20d 
>   plugins/bazaar/copyjob.cpp 68dce4ecd140a20127a19b02f6896ef2d89c7b96 
>   plugins/bazaar/diffjob.cpp 16187d17bc269b86b9f3adc1c43c388ee2a74235 
>   plugins/filetemplates/templateclassassistant.cpp f9e27e4387abb0bf2f9a2f54ff2ec0b9fdc3ebc8 
>   plugins/filetemplates/templatepreviewtoolview.cpp 5fe1e51337ed651c6367695e60008c42eb4f7b9d 
>   plugins/filetemplates/templateselectionpage.cpp dac99f46e0dccfcfd06630ac353cbf8a5aef2025 
>   plugins/filetemplates/testcasespage.cpp 4e395cf93fa0109efc3b99c6e9de05fbaef3f410 
>   plugins/git/gitclonejob.cpp 70ec36cfe5b1e2415c36bca0660d5f4540901976 
>   plugins/git/gitplugin.cpp c07911db717a1b841e2affd21b4e28bb437c739b 
>   plugins/git/gitplugincheckinrepositoryjob.cpp 1a62cacd3c043a0dbe73ce9812314efc3426180c 
>   plugins/git/stashmanagerdialog.cpp 8275cf460f2cd8314b5167bcc366b1dc70dc044c 
>   plugins/git/stashpatchsource.cpp 03804608b13b9d0ed7bba3c5315d6a3a2360b1e1 
>   plugins/grepview/grepdialog.cpp 0cb0563376c6cb8ca8c203f9e09605895242adfd 
>   plugins/grepview/grepjob.cpp 850f15b65ee807d2fd36e5fb202ace9de1765cec 
>   plugins/grepview/grepoutputmodel.cpp 81cb2b9f3c2efdd28cd325a5c5fb12f5029a3849 
>   plugins/grepview/grepoutputview.cpp f14b1700b8f98ddb8e86d45ada7a2d4c833b3eca 
>   plugins/grepview/grepviewplugin.cpp 0aaddb4b531e67446b75597c078c5b93da56939c 
>   plugins/filetemplates/outputpage.cpp 24b5ea7342bd80241662490fcf6403f5418b8dec 
>   plugins/filetemplates/overridespage.cpp 6a1282731b1198a4cea1fee0016ff2fea5d84de3 
>   plugins/documentview/kdevdocumentview.h eb307ab8745fa41d92e918debbe09f611533f35f 
>   plugins/documentview/kdevdocumentview.cpp 32e27eb38349ef860933a32ad17b190a12004bfb 
>   plugins/documentview/kdevdocumentviewplugin.cpp 2b9b637134cd8d94ecaa609e5560e5ce3352cd0a 
>   plugins/execute/nativeappconfig.cpp bd8883e8093e5dfa5d563907c4fc20c563e77283 
>   plugins/execute/nativeappjob.cpp 79ad1415416e196105eb0c76c8ca04a9fedcfd5c 
>   plugins/executescript/scriptappconfig.cpp 4bd2a17985ec72541ad42368a287f77ab0ef06e3 
>   plugins/executescript/scriptappjob.cpp 2f96d2099d8c0b213e8f68e8617ad6bf6ae940ac 
>   plugins/externalscript/editexternalscript.cpp 5e08f8f28309a76f05a8f8450f5fe0a1c166aa1b 
>   plugins/externalscript/externalscriptitem.cpp 555dda728caf2c86dfb62da755c9be1e3ed8bced 
>   plugins/externalscript/externalscriptjob.cpp 44753ef735940b4d6017778835d8955d2cb945d3 
>   plugins/externalscript/externalscriptplugin.cpp 968adb5567710e35ac8dfc7dfe9dc2efa367c2ea 
>   plugins/externalscript/externalscriptview.cpp 329a7f49aa5c77b64ee15df5bcc73d196545039d 
>   plugins/filemanager/filemanager.cpp 73081157d1bb0265db30bb48ef62eb105cfd2472 
>   plugins/filetemplates/classidentifierpage.cpp 65ec2db24211633b0ecfc46ec2fdf60102319866 
>   plugins/filetemplates/filetemplatesplugin.cpp 9ea20b6c7b4116abaeb89a433cb7ffdffa1aaa88 
>   plugins/filetemplates/licensepage.cpp f44088b9929d988e914a595610f9a77ca500eefb 
>   plugins/contextbrowser/contextbrowser.cpp de97edc883b1b351f79340e70a44de8a8bb31b19 
>   plugins/contextbrowser/contextbrowserview.cpp aeacb7913b7f8733124e7c03f82b7e5c0c07327b 
>   plugins/cvs/checkoutdialog.cpp 2807fdedc2176c90bbe3b217448b72e4622ddf1f 
>   plugins/cvs/cvsgenericoutputview.cpp 52908155430a90539582c48bb127cefda32d75c8 
>   plugins/cvs/cvsmainview.cpp ee0df0a55abcc5fe8027339c07fa08c984d394dd 
>   plugins/cvs/cvsplugin.cpp 925e5d8ec4b6f68815c72e0e6d081c5802a56197 
>   plugins/cvs/editorsview.cpp 10513d7e1916994604364766cf7db645a53aaa7b 
>   plugins/cvs/importdialog.cpp 4c6ef1cfa8f71934ffec1f196e2318861a38539e 
>   plugins/cvs/importmetadatawidget.cpp 3c978f3f0b47f21b663cb35e2843f00f3b2ac611 
>   plugins/documentswitcher/documentswitcherplugin.cpp eebd6163f7a74c50b1286a288917604620abdba6 
>   plugins/classbrowser/allclassesfolder.cpp 749151c76a256ac8e04c90367b56e7f36f0bbfc2 
>   plugins/classbrowser/classbrowserplugin.cpp b5d6a678d33870ab73e2ff9a92d44d7d478e3b5a 
>   plugins/classbrowser/classmodel.cpp 5ca922da5b3524c830ca105341161bffca8aabff 
>   plugins/classbrowser/classmodelnodescontroller.cpp 7f29a0e13f48bdad8847b15ac35e028947e711f5 
>   plugins/classbrowser/classtree.cpp 0463a135ea8e56ce3b10914aa5f18de5f28cbce8 
>   plugins/classbrowser/classwidget.cpp 798be66633f40ad728718e58c9ce8482594c48bf 
>   plugins/classbrowser/documentclassesfolder.cpp 3ec451034ffbd66d07fb019da173b00978dd8dcb 
>   plugins/contextbrowser/browsemanager.h 79426ce968d2e5bde76525f9c40814abbd46fb06 
>   plugins/contextbrowser/browsemanager.cpp c36e64644ed2b4f8242abd7135c9d63bcdba4bab 
>   plugins/contextbrowser/contextbrowser.h 18b2b1347490718fd1c960452d2a980680e5f45c 
> 
> Diff: https://git.reviewboard.kde.org/r/121045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141109/3264175a/attachment-0001.html>