Review Request 121055: convert all remaining files to new signal/slot syntax

Kevin Funk kfunk at kde.org
Sun Nov 9 14:40:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121055/#review70112
-----------------------------------------------------------


Note: There are a lot of new unit test failures after your patch series got pushed: http://build.kde.org/view/kdevelop/job/kdevplatform_master_qt5/294/

Please check.

- Kevin Funk


On Nov. 7, 2014, 6:25 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121055/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 6:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> convert all remaining files to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   app/plasma/dataengine/kdevelopsessionsengine.cpp 452a17f0921bb81e3801fb51e56b00efc57d6553 
>   app/plasma/runner/kdevelopsessions.cpp fb0a1eae5ad18b767ce3205134437acee224447b 
>   formatters/astyle/astyle_preferences.cpp 468785608490f3b854c5536ecf3dbcb1b0c141ea 
>   formatters/customscript/customscript_plugin.cpp 3aebbd47d4a2248f1e09051b2e2b746e17333a92 
>   providers/ghprovider/ghdialog.cpp 3e649e6c1e30dfd506f9d5437889f3e1cf533ed5 
>   providers/ghprovider/ghlineedit.cpp 6a62ccdd794c0480457ccb5ba91e58d8afaa185b 
>   providers/ghprovider/ghproviderwidget.cpp cd5aec80a0d2bf63b1343967ac07b7f88277e917 
>   providers/ghprovider/ghresource.cpp e8ff548253e1643effc5af79ed2ed3c15fa83afd 
> 
> Diff: https://git.reviewboard.kde.org/r/121055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141109/248941d4/attachment.html>


More information about the KDevelop-devel mailing list