Review Request 121046: Convert plugins to new signal/slot syntax (part2)

[Alexander Richardson]

> On Nov. 8, 2014, 7:43 nachm., Kevin Funk wrote:
> > plugins/standardoutputview/tests/CMakeLists.txt, line 12
> > <https://git.reviewboard.kde.org/r/121046/diff/1/?file=326938#file326938line12>
> >
> >     Hm, ugly to replicate the logic from ../CMakeLists.txt here. No other way?

I guess I could split out the K_PLUGIN_FACTORY macro into a separate file instead.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121046/#review70095
-----------------------------------------------------------


On Nov. 7, 2014, 6:36 nachm., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121046/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 6:36 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Convert projectmanagerview plugin to new signal/slot syntax
> 
> Convert patchreview plugin to new signal/slot syntax
> 
> 
> Convert vcschangesview plugin to new signal/slot syntax
> 
> 
> Convert reviewboard plugin to new signal/slot syntax
> 
> 
> Convert problemreporter plugin to new signal/slot syntax
> 
> 
> Convert quickopen plugin to new signal/slot syntax
> 
> 
> Convert standardoutputview plugin to new signal/slot syntax
> 
> 
> Convert testview plugin to new signal/slot syntax
> 
> 
> Convert templatemanager plugin to new signal/slot syntax
> 
> 
> Convert projectfilter plugin to new signal/slot syntax
> 
> 
> Convert all the remaining plugins to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectfilequickopen.cpp 5d49e278a2ee77c5ca81e18c11aa2cb19aed3f84 
>   plugins/quickopen/quickopenmodel.cpp b8c596e254b22c4da55993d2b62dc508b8fcfd89 
>   plugins/quickopen/quickopenplugin.cpp a8e619b8ce5ab78354148ca19c142eea6cff046e 
>   plugins/reviewboard/reviewboardjobs.h f971961402813cb727c8633452110e94b2c2c6bd 
>   plugins/reviewboard/reviewboardjobs.cpp 31721332975227265cf209034d0692af9a271414 
>   plugins/reviewboard/reviewboardplugin.cpp b77089e320cb60059cd7a1dfda8bd8cdb8e01a8e 
>   plugins/reviewboard/reviewpatchdialog.cpp 3ada692a8dec7a54adec5af0968d58795d0b901b 
>   plugins/standardoutputview/outputwidget.cpp 60729adb024a19cc7c4493998e9e6e52d8d8c5bd 
>   plugins/standardoutputview/standardoutputview.cpp 5a7d28ecfa8a9db9f62a3edae9929a20e00e158a 
>   plugins/standardoutputview/tests/CMakeLists.txt 88f2dde443578281fd1d5801f87e15f050e63b58 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp fdb3b967520a7a3e21e6e566f029f5b6117f8e00 
>   plugins/templatemanager/templatepage.cpp 93cff9a030f8bea233008c36710cd312db02b905 
>   plugins/testview/testview.cpp e15181674b7d6823da098912b2a4ebcea9cb37de 
>   plugins/testview/testviewplugin.cpp 3768726049f5ee057e000a56ae17e10a4b758bf4 
>   plugins/vcschangesview/vcschangesview.cpp b403f47b9bdbfc65df4e4c9d83448942bf52766b 
>   plugins/vcschangesview/vcschangesviewplugin.h bd826429bd850eb7c48d64e8325aeda909531cd8 
>   plugins/vcschangesview/vcschangesviewplugin.cpp 705e79c41e6fc4fc9c30892f8ec940d012670615 
>   plugins/welcomepage/sessionsmodel.cpp 4a28dc2695bd86e2fc1565eeb5f7b12b9e5c2139 
>   plugins/welcomepage/welcomepageview.cpp 3187ac12566a38eaecb32bc3799f3eeb5b1b78b9 
>   plugins/problemreporter/problemtreeview.cpp 47c2295d2db7a794295264a8e914f0099a569e8e 
>   plugins/problemreporter/watcheddocumentset.cpp 62e83281885e952db5c015d44aee4fb29d28078d 
>   plugins/projectfilter/projectfilterkcm.cpp 7eaba23ca09bfedb76fde50a4ff02b28b009c31a 
>   plugins/projectfilter/projectfilterprovider.cpp e22198349f02675572b1396e7a02bac1b43d2eb8 
>   plugins/projectmanagerview/projectbuildsetwidget.cpp e558ec1e11046fca2c96f6f01633ef6e3bee7e2e 
>   plugins/projectmanagerview/projectmanagerview.cpp 158ee70bdd3111e43ef7ad996ef95ceb43457940 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 78d85f8e0ee56c7f224256e9220c5dfa74cd2b30 
>   plugins/projectmanagerview/projecttreeview.cpp 6a83882a7e849968c65745459e88046690001257 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp 3f4f3ab1351097b071e951e1a58733b1289d06f6 
>   plugins/patchreview/patchreview.h a54695b5128c4cd9918e866c4432d7b4cb5c230a 
>   plugins/patchreview/patchreview.cpp ae7ed5159c329e7dd3836f3f3ee96ecd70e3d735 
>   plugins/patchreview/patchreviewtoolview.cpp 5bb33d80ad86a7bdd1a9ef63ae890293f00d1d96 
>   plugins/problemreporter/problemhighlighter.cpp e79ae592b2661e433209d6d09315d49ce34bde33 
>   plugins/problemreporter/problemmodel.cpp 41384a158b644749193677992586de68939bd74e 
>   plugins/problemreporter/problemreporterplugin.cpp 23d02aa511f3b6ee627ba3cf8227b667502ff4b6 
>   plugins/konsole/kdevkonsoleview.cpp 0aecaf210e37e43582a0e37336f14f197f41d1d0 
>   plugins/openwith/openwithplugin.cpp a04cd9c9a0506d1ed0c3c91b0fa6d8f26035894a 
>   plugins/pastebin/pastebinplugin.cpp 65331b42d508bc233b3b0c852eba5e066fa931a4 
>   plugins/patchreview/localpatchsource.cpp 1a178690e1bd44ca336c094a6f2d1492bbae568e 
>   plugins/patchreview/patchhighlighter.h c8ee098a2cc471974cbea5e8fc6d92936ae9495a 
>   plugins/patchreview/patchhighlighter.cpp ed2ba897a53162080726b62ca39de36648c6c3d0 
> 
> Diff: https://git.reviewboard.kde.org/r/121046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/262a5309/attachment-0001.html>