Review Request 121061: Fix environment-cd when launching a debugsession in a path containing spaces

[Nicolas Werner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121061/
-----------------------------------------------------------

(Updated Nov. 8, 2014, 3:53 nachm.)


Review request for KDevelop.


Changes
-------

Simplify patch, use patch for 4.7er branch 
(Did I understand it right, that I should publish the patch for 4.7, that I could test on my PC? It will have a merge conflict with master, because of the change from QString to QUrl)


Bugs: 339231
    http://bugs.kde.org/show_bug.cgi?id=339231


Repository: kdevelop


Description
-------

Problem: GDBMI only accepts paths containing spaces if they are in double quotes otherwise cd will fail.
Solution: Add prepend and append double quotes to the dir string instead of using KShell::quoteArg


Diffs (updated)
-----

  debuggers/gdb/debugsession.cpp e37c5b7 

Diff: https://git.reviewboard.kde.org/r/121061/diff/


Testing
-------

I did a patch for 4.7, that fixed the problem, but I can't build master at the moment, so I don't know, if this compiles. It should fix the bug tough, as it is only a quoting issue.

Should I also attatch the patch for the 4.7 branch?


Thanks,

Nicolas Werner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/daac1bad/attachment.html>