Review Request 120317: WIP: Config pages without KCMs

Milian Wolff mail at milianw.de
Sat Nov 8 15:05:42 UTC 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120317/#review70069
-----------------------------------------------------------



interfaces/configpage.h
<https://git.reviewboard.kde.org/r/120317/#comment49036>

    is this overriding anything? if so, please mark it as such.



interfaces/configpage.h
<https://git.reviewboard.kde.org/r/120317/#comment49037>

    override? if not: can this be const?



interfaces/configpage.h
<https://git.reviewboard.kde.org/r/120317/#comment49035>

    const



interfaces/configpage.h
<https://git.reviewboard.kde.org/r/120317/#comment49038>

    const?



interfaces/configpage.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49039>

    style
    
        Foo::Foo()
          : Base(...)
          , d(...)
        {}



interfaces/configpage.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49040>

    indent. same below



interfaces/iplugin.h
<https://git.reviewboard.kde.org/r/120317/#comment49041>

    can this be const?



interfaces/iplugin.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49042>

    Q_UNREACHABLE() ?



plugins/projectfilter/projectfilterkcm.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49043>

    can the newstyle syntax be used?



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49045>

    probably yes, we want to flush it before we upload it after all



util/environmentconfigurebutton.cpp
<https://git.reviewboard.kde.org/r/120317/#comment49046>

    remove ()


- Milian Wolff


On Oct. 28, 2014, 12:37 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120317/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 12:37 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Everything seems to work fine with the converted config pages.
> 
> This is a huge diff, should I maybe push my changes to a new branch or to some other repository?
> 
> 
> Diffs
> -----
> 
>   util/environmentconfigurebutton.h 9a6503801cb9cdb9384bb68ac8cc7cd4559c12d9 
>   util/environmentconfigurebutton.cpp 23703e95ef1ebdb1f5d0bfa087dd9ca297f9dae1 
>   shell/settings/sourceformattersettings.cpp 982d114e04b7d8eab7e986cc465ef8bb7086f288 
>   shell/settings/uipreferences.h 34c46f3902cf06156c7f8279e6672ebb7a06a31e 
>   shell/settings/uipreferences.cpp c8ba26201516241e29f76db4c6e448de787c4704 
>   shell/uicontroller.h 797fa198ed17608e88f2a9e9a03f8072c5ebf45d 
>   shell/uicontroller.cpp 64b75099026a31d4e85f30ec7127bc24c9ba1882 
>   util/CMakeLists.txt e059d0ec5ed28d4543e10124e8671efbf783de25 
>   shell/settings/projectconfig.kcfgc 31355435eff9d2306ce98219095ecf02283cc2e9 
>   shell/settings/projectpreferences.h 18a5357829a4293ba284868ca6be6c33134ef8da 
>   shell/settings/projectpreferences.cpp 807819f8bdb261a24f79056aa4704fc8c38a2c10 
>   shell/settings/sourceformattersettings.h e27933c45309ed763db24be1d0ed19d4a183e861 
>   shell/settings/pluginpreferences.h 12f9d233d9a06739ff0e460e5c41ff92f9431af3 
>   shell/settings/pluginpreferences.cpp 0c930961ed55b64fccd56f611cfd48b5a99eb55e 
>   shell/settings/kcm_kdev_pluginsettings.desktop.cmake 10d126ed24adc10d3e6f7183d7b97677c661287e 
>   shell/settings/kcm_kdev_projectsettings.desktop.cmake b1ac9bc4d59a2b3128745ceae79a3b66eda08245 
>   shell/settings/kcm_kdev_uisettings.desktop.cmake 336e233c2cb1570a2d8523680938f1d094a9a915 
>   shell/settings/kcm_kdevsourceformattersettings.desktop.cmake 6f22083488be2d4ad350ab5293a25c56e0797e43 
>   shell/settings/environmentpreferences.cpp d663bc363ec847fcab677680b14d9c7cbd6369b3 
>   shell/settings/kcm_kdev_bgsettings.desktop.cmake 374e041f35bf49422a76096fa15ced9e6dcef587 
>   shell/settings/kcm_kdev_ccsettings.desktop.cmake 56f8394d7ff93bf755f3771471f9c8528bda9d98 
>   shell/settings/kcm_kdev_envsettings.desktop.cmake 5fe88f5a9ddc90ae8cc6078e5b67b159ede5a2eb 
>   shell/settings/bgpreferences.cpp 5f5332855d7d6189899cf4e879dd92e3ef48e188 
>   shell/settings/ccpreferences.h 186b62a09e2fd10a9937689d919d05911e3d77e0 
>   shell/settings/ccpreferences.cpp 0817977482f688d1f12d30f4eaa1e67166b70de0 
>   shell/settings/environmentpreferences.h e7c84f4ec750ace28489829eced5bfc0b9c66718 
>   shell/settings/bgconfig.kcfgc 8dfe6e314a14972b725f97d341ce6fa5b2795349 
>   shell/settings/bgpreferences.h e516b6395beda6d964cea72c35e694038b84f71a 
>   shell/configdialog.h PRE-CREATION 
>   shell/configdialog.cpp PRE-CREATION 
>   shell/editorconfigpage.h PRE-CREATION 
>   shell/editorconfigpage.cpp PRE-CREATION 
>   shell/plugincontroller.cpp d8679afa637bf5f91a4fc9565639766e49ebac83 
>   shell/projectcontroller.h 08cb7cbfec32cac918d674ed9a076ce9286ffd30 
>   shell/projectcontroller.cpp e549155a3b7fc3ac3e6c642c2c9e2c123af11b7c 
>   shell/settings/CMakeLists.txt adde8f22976732e5e5280cea3289caddd40f8b94 
>   plugins/templatemanager/templatepage.h ed8a703e6919146b762d657e35d379c33687c74d 
>   plugins/templatemanager/templatepage.cpp 93cff9a030f8bea233008c36710cd312db02b905 
>   plugins/templatemanager/templatepage.ui  
>   project/CMakeLists.txt 948e7ffd8a1e4c8fd4982ed1ad208c7b616bc637 
>   project/interfaces/iprojectbuilder.h c47573a6867c3f81ced411bd973becc29b0c7b94 
>   project/projectconfigpage.h PRE-CREATION 
>   project/projectkcmodule.h fe40e9c3ad05963a5c7986110d1d4cb3e3fa5438 
>   shell/CMakeLists.txt d30897867af75bda6054852925ae39f8b08c80b7 
>   plugins/execute/nativeappconfig.cpp b0eca9c9712b6a4ff2759180c54a35cc0168fe0f 
>   plugins/execute/nativeappconfig.ui 63954d3543a5aa4601625f426dfc552a822716ce 
>   plugins/projectfilter/CMakeLists.txt 7fc4226bc253e033633916d058f0fc32a1f4cb6f 
>   plugins/projectfilter/kcm_kdevprojectfilter.desktop.cmake 2d728b3fcb6b0cd8b6976771a214f270995bc2b7 
>   plugins/projectfilter/projectfilterkcm.h 01d143469528117589c86853e5847fad6bc2aaaf 
>   plugins/projectfilter/projectfilterkcm.cpp 7eaba23ca09bfedb76fde50a4ff02b28b009c31a 
>   plugins/projectfilter/projectfilterprovider.h cb1fa978e0c40fcf8cf5e3fcaf73294c1b9d314e 
>   plugins/projectfilter/projectfilterprovider.cpp e22198349f02675572b1396e7a02bac1b43d2eb8 
>   plugins/templatemanager/CMakeLists.txt 5d0eec1fd6457aefee776a2bff866cf4d27d08a9 
>   plugins/templatemanager/Messages.sh  
>   plugins/templatemanager/kdevtemplatemanager_config.desktop.cmake 018b2789eabe97d8ee9f2286783de92526c8a5ba 
>   plugins/templatemanager/templateconfig.h 2dcab9075c16351fcccdf8725f4c96efd2ab1ca9 
>   plugins/templatemanager/templateconfig.cpp 286bd7ccf20df6075eb915a66f9c5ce40c29b3d2 
>   plugins/templatemanager/templateconfig.ui  
>   CMakeLists.txt 3f208a6d31a00bbe3a1a51ff7d82b1794e53099a 
>   interfaces/CMakeLists.txt 4f7fc1c7d9bd93865e4db5aac71349fbfa3b0d09 
>   interfaces/configpage.h PRE-CREATION 
>   interfaces/configpage.cpp PRE-CREATION 
>   interfaces/iplugin.h b101ae46fa430101c21a1c8eb8699674cbb1977b 
>   interfaces/iplugin.cpp a17cd173c1836fc298a3f66f3066f0e4520c8510 
>   plugins/CMakeLists.txt 46a0b471e6dd06889ef510a1e7b0c18157345157 
>   plugins/execute/CMakeLists.txt 3bb38a5d0279e21997513df205e170183d343b20 
> 
> Diff: https://git.reviewboard.kde.org/r/120317/diff/
> 
> 
> Testing
> -------
> 
> Dialog is shown correctly, apply, okay work correctly.
> 
> Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)
> 
> 
> File Attachments
> ----------------
> 
> kdev_config_new.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png
> kdev_config_new1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/f4f16e26-e6dd-4c98-9969-588342f85f4c__kdev_config_new1.png
> plugin enabled -> entry exists
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/7130af0f-5e23-45cf-b781-ebe318be8369__kdev_config_new2.png
> plugin unloaded -> entry disappears
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/dff38c1f-2b3d-4ab7-a97d-adff0a99bb3d__kdev_config_new3.png
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/91575995/attachment-0001.html>

More information about the KDevelop-devel mailing list