Review Request 121036: Convert util/ to Qt5 signal/slot syntax

[Milian Wolff]

> On Nov. 8, 2014, 9:27 a.m., Kevin Funk wrote:
> > util/objectlist.cpp, line 67
> > <https://git.reviewboard.kde.org/r/121036/diff/1/?file=326725#file326725line67>
> >
> >     Hm, why do you add the private method in the public header? Can't you use a lambda as slot here, too?
> 
> Alexander Richardson wrote:
>     The we would need to store all the `QMetaObject::Connection`s that are returned by the connect call with the lambda. disconnect() only works with pointer-to-member

ok fair enough.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121036/#review70028
-----------------------------------------------------------


On Nov. 7, 2014, 5:34 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121036/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Convert util/ to Qt5 signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   util/duchainify/main.cpp fb0ae318e40a80ce9dc60386e4672663acb1961e 
>   util/environmentconfigurebutton.cpp 23703e95ef1ebdb1f5d0bfa087dd9ca297f9dae1 
>   util/focusedtreeview.cpp 9050c30469a4834ab654128811905f3d0005adf5 
>   util/multilevellistview.cpp cb5f08c85bdcddcaafdac716566a8f7c78da0322 
>   util/objectlist.h 43ec0f474b7423de9b86eeb54928f660513492c7 
>   util/objectlist.cpp c4b01af408866004ca6f40bf1b6dc44eb9a8405e 
>   util/processlinemaker.cpp f95d3781832e63f4c3a50156ea91c6c4bbb05eb6 
>   util/projecttestjob.cpp 677c88b6750d5f59d6d9f32a288e5ee9f9249043 
>   util/commandexecutor.cpp 097868aa6044d5ce603626d1663f825a347dbe78 
>   util/activetooltip.cpp 0357842268d989d9f6c2008d5df239bd4a0f8432 
> 
> Diff: https://git.reviewboard.kde.org/r/121036/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/21c05ed5/attachment-0001.html>