Review Request 121037: Convert sublime/ to Qt5 signal/slot syntax

Milian Wolff mail at milianw.de
Sat Nov 8 12:44:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121037/#review70053
-----------------------------------------------------------

Ship it!



sublime/controller.h
<https://git.reviewboard.kde.org/r/121037/#comment49009>

    I dislike that. could you instead use a lambda where appropriate? Or alternatively make signature typesafe and use a lambda to do the casting.



sublime/document.cpp
<https://git.reviewboard.kde.org/r/121037/#comment49010>

    and whitespace after ]. But in theory this is exactly what I want for the Controller functions I commented on above.



sublime/mainwindow.cpp
<https://git.reviewboard.kde.org/r/121037/#comment49011>

    here and below: whitepsace after ], remove `this`.



sublime/view.cpp
<https://git.reviewboard.kde.org/r/121037/#comment49012>

    also remove `()`


- Milian Wolff


On Nov. 7, 2014, 5:34 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121037/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Convert sublime/ to Qt5 signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   sublime/area.cpp 62dd90c446eb7b034bc481a6ba05e2ca85959be4 
>   sublime/container.cpp 9db2c40fb3796a2a63648c48268685d8bf814355 
>   sublime/controller.h a36163118ac9a38b5ae997aa70b3e556c91cdde8 
>   sublime/controller.cpp bd50d0533a92feaf1e90da9fc388b516c849bfc5 
>   sublime/document.cpp 780653a08c61db88d963e3329e2837f58dbc4bd1 
>   sublime/examples/example1main.cpp 8ece5cca4c09a82d5b3b12291dc048a47497ac76 
>   sublime/idealbuttonbarwidget.cpp 21ac2e2997c2a3e4346284d5413386f3318d6ecc 
>   sublime/idealcontroller.cpp f8b67acbc9a0d7bbae5429c93cf44bdc374dd96e 
>   sublime/idealdockwidget.cpp 897862b6428f280b0ce5ba8620237527972d4cbf 
>   sublime/mainwindow.cpp 6f760d6ab7c139eb5ebb71828eca26963100bbcd 
>   sublime/mainwindow_p.cpp b2982eb085df288155d00a32a26a02ad6c386737 
>   sublime/view.cpp ab95ed78568a0fdfb2bd56c50e55bd7174f885b0 
> 
> Diff: https://git.reviewboard.kde.org/r/121037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/e40a9f1d/attachment.html>


More information about the KDevelop-devel mailing list