Review Request 121041: convert project/ to new signal/slot syntax

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121041/#review70049
-----------------------------------------------------------

Ship it!



project/abstractfilemanagerplugin.cpp
<https://git.reviewboard.kde.org/r/121041/#comment48994>

    style: add a whitespace after the ]. also below please



project/abstractfilemanagerplugin.cpp
<https://git.reviewboard.kde.org/r/121041/#comment48995>

    add a newline after the {, it's pretty long line this way.



project/abstractfilemanagerplugin.cpp
<https://git.reviewboard.kde.org/r/121041/#comment48996>

    share the lambda? not sure whether thats worth it.


- Milian Wolff


On Nov. 7, 2014, 5:34 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121041/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 5:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> convert project/ to new signal/slot syntax
> 
> 
> Diffs
> -----
> 
>   project/abstractfilemanagerplugin.cpp c26cf5b59b8e03c05beef701d46caac6a0096934 
>   project/filemanagerlistjob.cpp d875e03d5dcba1342b9bd2485b17f8e8e08d177f 
>   project/importprojectjob.cpp f04638e8a797853aad0137b9e407d49b427a4048 
>   project/projectfiltermanager.cpp fc3850962f58525effae977692a12d9e1c983237 
>   project/projectitemlineedit.cpp 298fbba6b210061f9e37d0b7c71a06d040d2588a 
>   project/projectutils.cpp 43ae9c07a5a3dfd518b8c11b19dbe236fc9b6e3a 
>   project/tests/projectmodelperformancetest.cpp e82a51d7ab207a5d98a48cb0a95a5904eafde6b1 
> 
> Diff: https://git.reviewboard.kde.org/r/121041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/fe9ac58c/attachment.html>