Review Request 121061: Fix environment-cd when launching a debugsession in a path containing spaces

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121061/#review70044
-----------------------------------------------------------

Ship it!


please fix the issue before pushing it into the 1.7  branch. This will then be merged up into master.


debuggers/gdb/debugsession.cpp
<https://git.reviewboard.kde.org/r/121061/#comment48993>

    just make this
    
        queueCmd(new GDBCommand(GDBMI::EnvironmentCd,
                                '"' + dir.toLocalFile() + '"'));


- Milian Wolff


On Nov. 7, 2014, 11:07 p.m., Nicolas Werner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121061/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 11:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 339231
>     http://bugs.kde.org/show_bug.cgi?id=339231
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Problem: GDBMI only accepts paths containing spaces if they are in double quotes otherwise cd will fail.
> Solution: Add prepend and append double quotes to the dir string instead of using KShell::quoteArg
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp 1ade53a 
> 
> Diff: https://git.reviewboard.kde.org/r/121061/diff/
> 
> 
> Testing
> -------
> 
> I did a patch for 4.7, that fixed the problem, but I can't build master at the moment, so I don't know, if this compiles. It should fix the bug tough, as it is only a quoting issue.
> 
> Should I also attatch the patch for the 4.7 branch?
> 
> 
> Thanks,
> 
> Nicolas Werner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141108/22bfee74/attachment.html>