Review Request 120963: Convert interfaces/ and outputview/ to new signal slot syntax

[Milian Wolff]

> On Nov. 3, 2014, 10:40 p.m., Milian Wolff wrote:
> > outputview/outputmodel.cpp, line 207
> > <https://git.reviewboard.kde.org/r/120963/diff/1/?file=325091#file325091line207>
> >
> >     why not `model, &OutputModel::linesParsed`? I.e. why is the lambda required here?
> >     
> >     or is this a private slot, then it means the private slot can be removed, no?
> 
> Alexander Richardson wrote:
>     Yes, it's a private slot. We could make it a normal private method so that we don't need the lambda.
> 
> Milian Wolff wrote:
>     see above. remove the unused private slot and stick to the lambda. It's nice to hide private things in the .cpp. The private slots where required before, but not anymore thanks to lambdas.
> 
> Alexander Richardson wrote:
>     Just noticed it doesn't compile after all, IOutputView is not a QObject, so it can't have a Q_OBJECT macro.
>     
>     Should it be changed to inherit from QObject? Any subclasses will anyway, so I doubt this changes anything.
> 
> Alexander Richardson wrote:
>     Hmm, this won't work either, multiple inheritance from QObject doesn't work...
>     
>     The problem is that we have `class StandardOutputView : public KDevelop::IPlugin, public KDevelop::IOutputView`
>     
>     Any ideas how to fix this?

Yes, by not using the new-style connect syntax :). I've cleaned up the patch locally and will commit it now (under your name). You can take a look at that version then to see what else I changed.

Thanks!


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120963/#review69770
-----------------------------------------------------------


On Nov. 3, 2014, 9:50 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120963/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 9:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Fixes one bad connection in outputjob.cpp
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.cpp 5bc7ada39321e228a4deb618acca8343bae0a38e 
>   interfaces/iplugin.cpp 2b7ae9397f97455bc065f58ef13e6cee2e6e33e8 
>   outputview/outputexecutejob.cpp 3a3b983bc3779ca6676f0b732c10d3499c1fc177 
>   outputview/outputjob.cpp fe9a984f03f9e21a09bc3adf8169ceb908841381 
>   outputview/outputmodel.cpp b7846a24de1eb4ea46356d5b77f6c9a1bdb123a7 
> 
> Diff: https://git.reviewboard.kde.org/r/120963/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141105/a29be00e/attachment.html>