Review Request 120962: Git version check. Make most significant digit decide if version is suitable

Morten Volden mvolden2 at gmail.com
Tue Nov 4 16:50:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120962/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 4:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevplatform


Description
-------

Change the behavior of git version check so that it will now acknowledge that git version 2.1.0 is Newer than 1.7. Also a version equal of 1.7 will now not be considered too old (Which I assume is desired behaviour)


Diffs
-----

  plugins/git/gitplugin.cpp a4118e4 

Diff: https://git.reviewboard.kde.org/r/120962/diff/


Testing
-------

Build it, and ran kdevelop. It seems to give the expected result. 

kdevplatform.plugins.git: checking git version ("2", "1", "0") against (1, 7)
kdevplatform.plugins.git: the current git version is old:  false


Thanks,

Morten Volden

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141104/47548c7e/attachment.html>


More information about the KDevelop-devel mailing list