Review Request 120962: Git version check. Make most significant digit decide if version is suitable

[Morten Volden]

> On Nov. 3, 2014, 9:13 p.m., Milian Wolff wrote:
> > why not simply take the old code, but rewrite it to
> > 
> >     m_oldVersion = false;
> >     foreach (...) {
> >         ...
> >         if (valcurr < num) {
> >             m_oldVersion = true;
> >             break;
> >         }
> >     }

Done :-)


- Morten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120962/#review69759
-----------------------------------------------------------


On Nov. 3, 2014, 9:49 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120962/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 9:49 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Change the behavior of git version check so that it will now acknowledge that git version 2.1.0 is Newer than 1.7. Also a version equal of 1.7 will now not be considered too old (Which I assume is desired behaviour)
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp a4118e4 
> 
> Diff: https://git.reviewboard.kde.org/r/120962/diff/
> 
> 
> Testing
> -------
> 
> Build it, and ran kdevelop. It seems to give the expected result. 
> 
> kdevplatform.plugins.git: checking git version ("2", "1", "0") against (1, 7)
> kdevplatform.plugins.git: the current git version is old:  false
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141103/41c17d3d/attachment.html>